Skip to content

Commit

Permalink
Update CI configs to v0.11.15
Browse files Browse the repository at this point in the history
Update lint scripts and CI configs.
  • Loading branch information
pionbot authored and Sean-Der committed Aug 16, 2024
1 parent 5bb0d65 commit 6412031
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 15 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
uses: pion/.goassets/.github/workflows/test.reusable.yml@master
strategy:
matrix:
go: ["1.22", "1.21"] # auto-update/supported-go-version-list
go: ["1.23", "1.22"] # auto-update/supported-go-version-list
fail-fast: false
with:
go-version: ${{ matrix.go }}
Expand All @@ -33,13 +33,13 @@ jobs:
uses: pion/.goassets/.github/workflows/test-i386.reusable.yml@master
strategy:
matrix:
go: ["1.22", "1.21"] # auto-update/supported-go-version-list
go: ["1.23", "1.22"] # auto-update/supported-go-version-list
fail-fast: false
with:
go-version: ${{ matrix.go }}

test-wasm:
uses: pion/.goassets/.github/workflows/test-wasm.reusable.yml@master
with:
go-version: "1.22" # auto-update/latest-go-version
go-version: "1.23" # auto-update/latest-go-version
secrets: inherit
8 changes: 4 additions & 4 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# SPDX-FileCopyrightText: 2023 The Pion community <https://pion.ly>
# SPDX-License-Identifier: MIT

run:
timeout: 5m

linters-settings:
govet:
enable:
Expand Down Expand Up @@ -48,7 +51,7 @@ linters:
- goconst # Finds repeated strings that could be replaced by a constant
- gocritic # The most opinionated Go source code linter
- godox # Tool for detection of FIXME, TODO and other comment keywords
- goerr113 # Golang linter to check the errors handling expressions
- err113 # Golang linter to check the errors handling expressions
- gofmt # Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification
- gofumpt # Gofumpt checks whether code was gofumpt-ed.
- goheader # Checks is file header matches to pattern
Expand Down Expand Up @@ -83,17 +86,14 @@ linters:
- depguard # Go linter that checks if package imports are in a list of acceptable packages
- containedctx # containedctx is a linter that detects struct contained context.Context field
- cyclop # checks function and package cyclomatic complexity
- exhaustivestruct # Checks if all struct's fields are initialized
- funlen # Tool for detection of long functions
- gocyclo # Computes and checks the cyclomatic complexity of functions
- godot # Check if comments end in a period
- gomnd # An analyzer to detect magic numbers.
- ifshort # Checks that your code uses short syntax for if-statements whenever possible
- ireturn # Accept Interfaces, Return Concrete Types
- lll # Reports long lines
- maintidx # maintidx measures the maintainability index of each function.
- makezero # Finds slice declarations with non-zero initial length
- maligned # Tool to detect Go structs that would take less memory if their fields were sorted
- nakedret # Finds naked returns in functions greater than a specified function length
- nestif # Reports deeply nested if statements
- nlreturn # nlreturn checks for a new line before return and branch statements to increase code clarity
Expand Down
10 changes: 5 additions & 5 deletions logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ func (ll *DefaultLeveledLogger) SetLevel(newLevel LogLevel) {

// Trace emits the preformatted message if the logger is at or below LogLevelTrace
func (ll *DefaultLeveledLogger) Trace(msg string) {
ll.logf(ll.trace, LogLevelTrace, msg)
ll.logf(ll.trace, LogLevelTrace, msg) // nolint: govet

Check warning on line 108 in logger.go

View check run for this annotation

Codecov / codecov/patch

logger.go#L108

Added line #L108 was not covered by tests
}

// Tracef formats and emits a message if the logger is at or below LogLevelTrace
Expand All @@ -115,7 +115,7 @@ func (ll *DefaultLeveledLogger) Tracef(format string, args ...interface{}) {

// Debug emits the preformatted message if the logger is at or below LogLevelDebug
func (ll *DefaultLeveledLogger) Debug(msg string) {
ll.logf(ll.debug, LogLevelDebug, msg)
ll.logf(ll.debug, LogLevelDebug, msg) // nolint: govet
}

// Debugf formats and emits a message if the logger is at or below LogLevelDebug
Expand All @@ -125,7 +125,7 @@ func (ll *DefaultLeveledLogger) Debugf(format string, args ...interface{}) {

// Info emits the preformatted message if the logger is at or below LogLevelInfo
func (ll *DefaultLeveledLogger) Info(msg string) {
ll.logf(ll.info, LogLevelInfo, msg)
ll.logf(ll.info, LogLevelInfo, msg) // nolint: govet

Check warning on line 128 in logger.go

View check run for this annotation

Codecov / codecov/patch

logger.go#L128

Added line #L128 was not covered by tests
}

// Infof formats and emits a message if the logger is at or below LogLevelInfo
Expand All @@ -135,7 +135,7 @@ func (ll *DefaultLeveledLogger) Infof(format string, args ...interface{}) {

// Warn emits the preformatted message if the logger is at or below LogLevelWarn
func (ll *DefaultLeveledLogger) Warn(msg string) {
ll.logf(ll.warn, LogLevelWarn, msg)
ll.logf(ll.warn, LogLevelWarn, msg) // nolint: govet
}

// Warnf formats and emits a message if the logger is at or below LogLevelWarn
Expand All @@ -145,7 +145,7 @@ func (ll *DefaultLeveledLogger) Warnf(format string, args ...interface{}) {

// Error emits the preformatted message if the logger is at or below LogLevelError
func (ll *DefaultLeveledLogger) Error(msg string) {
ll.logf(ll.err, LogLevelError, msg)
ll.logf(ll.err, LogLevelError, msg) // nolint: govet
}

// Errorf formats and emits a message if the logger is at or below LogLevelError
Expand Down
6 changes: 3 additions & 3 deletions logging_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func testDebugLevel(t *testing.T, logger *logging.DefaultLeveledLogger) {
if !strings.Contains(outBuf.String(), dbgMsg) {
t.Errorf("Expected to find %q in %q, but didn't", dbgMsg, outBuf.String())
}
logger.Debugf(dbgMsg)
logger.Debugf(dbgMsg) // nolint: govet
if !strings.Contains(outBuf.String(), dbgMsg) {
t.Errorf("Expected to find %q in %q, but didn't", dbgMsg, outBuf.String())
}
Expand All @@ -50,7 +50,7 @@ func testWarnLevel(t *testing.T, logger *logging.DefaultLeveledLogger) {
if !strings.Contains(outBuf.String(), warnMsg) {
t.Errorf("Expected to find %q in %q, but didn't", warnMsg, outBuf.String())
}
logger.Warnf(warnMsg)
logger.Warnf(warnMsg) // nolint: govet
if !strings.Contains(outBuf.String(), warnMsg) {
t.Errorf("Expected to find %q in %q, but didn't", warnMsg, outBuf.String())
}
Expand All @@ -65,7 +65,7 @@ func testErrorLevel(t *testing.T, logger *logging.DefaultLeveledLogger) {
if !strings.Contains(outBuf.String(), errMsg) {
t.Errorf("Expected to find %q in %q, but didn't", errMsg, outBuf.String())
}
logger.Errorf(errMsg)
logger.Errorf(errMsg) // nolint: govet
if !strings.Contains(outBuf.String(), errMsg) {
t.Errorf("Expected to find %q in %q, but didn't", errMsg, outBuf.String())
}
Expand Down

0 comments on commit 6412031

Please sign in to comment.