Bump sctp to v1.8.33 #2871
Closed
Bump sctp to v1.8.33 #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
commented
Aug 13, 2024
| github.com/pion/sdp/v3 v3.0.9 | ||
| github.com/pion/srtp/v2 v2.0.20 | ||
| github.com/pion/stun v0.6.1 | ||
| github.com/pion/transport/v2 v2.2.10 | ||
| github.com/sclevine/agouti v3.0.0+incompatible | ||
| github.com/stretchr/testify v1.9.0 | ||
| golang.org/x/net v0.22.0 | ||
| golang.org/x/net v0.27.0 |
There was a problem hiding this comment.
this required a go mod tidy -go=1.16 && go mod tidy -go=1.17 which is nonsense to me
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #2871 +/- ##
==========================================
- Coverage 80.16% 80.11% -0.06%
==========================================
Files 78 78
Lines 7614 7614
==========================================
- Hits 6104 6100 -4
- Misses 1074 1077 +3
- Partials 436 437 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@edaniels want me to merge this? |
|
This would break 1.19 if we did so I think we gotta figure that out first? |
|
@edaniels I am going to release If you disagree I am happy to figure out something else we can do here! |
|
aye aye |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting for tests