-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Register upload handlers in config #50
Comments
Hi, you already do not need to implement the whole library, you can call Anyway, you have a point. It would be easier to provider entry in config. I would not recommend to have in-built handlers in config (updating would be harder), but we could allow user to override the handlers. This should be pretty easy. ... config
'handlers' => [
// A list of handlers/providers that will be appended to existing list of handlers
'custom' => []
// Overrides the list of handlers - use only what you really want
'override' => []
] |
Hello, You are right. It seems I did not read carefully enough and missed that part. Currently I registered the library as a local repository with composer to be able to add a handler. You are right about the problems with update process. And this configuration idea looks promissing. |
Working on it |
I've updated the wiki:
Integration is updated to use config. Service provider is now partly unit tested (to cover this change). |
It would be great if the handler registration would be in the config file intead in the
HandlerFactory
. So handlers could work similarly to providers. This would make the library more extendable.What do you think about this?
The text was updated successfully, but these errors were encountered: