Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L9 support #129

Closed
wants to merge 3 commits into from
Closed

L9 support #129

wants to merge 3 commits into from

Conversation

drjdr
Copy link
Contributor

@drjdr drjdr commented Feb 28, 2022

Hi,

this is just a PR as POC for the adjustments for L9.
My setup uses only PHP 8.1 and L9, so I didnt remove the old releases.
Given the recent changes in Flysystem v3 I would do the following:

  • Make the update only available for L ^9.0
  • Tag this as a 2.0.0 release

@pionl
Copy link
Owner

pionl commented Mar 21, 2022

Hi @drjdr , this is perfect, I was expecting I had to do this (already did this on diff project).

I'm going to test it on older PHP versions and we will see, 30% ppl are stil using 7.4. https://packagist.org/packages/pion/laravel-chunk-upload/php-stats

@pionl pionl mentioned this pull request Mar 21, 2022
@pionl
Copy link
Owner

pionl commented Mar 21, 2022

As for this moment I wont drop older releases due the "older" state of the package and old usages.

Of course I would encourage everybody to upgrade to latest Laravel. I've dropped only Laravel 5/6. Other I am able to test via example repository + docker.

With little effort we can still support old versions. I've changed your code.

Unfortunately I'm not using the package anymore so my priorities are not here any more :( Maybe in future I will need it again and I will upgrade it with PHP 8.1 code base and major refactoring of some bad design choices.

Imho, I've updated the tests in chunk example and every test is Ok now. Took some time but managed it to fix all issues with it.

Thanks for the PR.

Tested on PHP 8.1 / 8.0 / 7.4 (Laravel below 9) - see example repository for more details.

@pionl pionl closed this Mar 21, 2022
@pionl pionl mentioned this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants