Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usePullRequestMetadata option to use PR metadata instead of commit message #24

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Add usePullRequestMetadata option to use PR metadata instead of commit message #24

merged 2 commits into from
Mar 3, 2022

Conversation

knanao
Copy link
Member

@knanao knanao commented Mar 2, 2022 •
edited
Loading

Overview

It enable to create release note to use PR's release block or PR's title instead of commit messages.

Issue

https://github.com/pipe-cd/actions-gh-release/issues/22

Note

Rate limit

This implementation call github REAT API in order to get PR metadata per merge-commit.
Hence, If one release contains a lot of merge-commits or you release really frequently, it’s possible to exceed the rate limit.
ref: Request from Github Action

When using GITHUB_TOKEN, the rate limit is 1,000 requests per hour per repository.
For requests to resources that belong to an enterprise account on GitHub.com,
GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000 requests per hour per repository.

@knanao knanao force-pushed the use-default-merge-commit branch 6 times, most recently from b729e25 to e41c9dc Compare March 3, 2022 01:47
nghialv
nghialv reviewed Mar 3, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
nghialv
nghialv reviewed Mar 3, 2022
View reviewed changes
release.go Outdated Show resolved Hide resolved
@knanao knanao force-pushed the use-default-merge-commit branch 2 times, most recently from 5f8762b to 8d17ec5 Compare March 3, 2022 04:48
@knanao
Copy link
Member Author

knanao commented Mar 3, 2022

@nghialv
I fixed from your reviews.
PTAL, when you can do it.

@knanao knanao force-pushed the use-default-merge-commit branch 2 times, most recently from 3ea0732 to ee694f6 Compare March 3, 2022 05:49
@knanao knanao changed the title Add UseDefaultMergeCommitParser option Add usePullRequestMetadata option to use PR metadata instead of commit message Mar 3, 2022
knanao
knanao commented Mar 3, 2022
View reviewed changes
github.go Show resolved Hide resolved
nghialv
nghialv reviewed Mar 3, 2022
View reviewed changes
release.go Outdated Show resolved Hide resolved
@nghialv
Copy link
Member

nghialv commented Mar 3, 2022

@knanao Great Job!

Just some nits. Please check them.

@nghialv
Copy link
Member

nghialv commented Mar 3, 2022

Thank you so much. Here you go.
/approve

@nghialv nghialv merged commit 4010710 into main Mar 3, 2022
@nghialv nghialv deleted the use-default-merge-commit branch March 3, 2022 07:59
@knanao knanao mentioned this pull request Mar 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghialv nghialv nghialv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knanao @nghialv