Format func params and comment

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
pipe-cd · Jul 8, 2024 · 5103158 · 5103158
1 parent d17a9b7
commit 5103158
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 4 deletions.
diff --git a/pkg/app/piped/executor/ecs/ecs.go b/pkg/app/piped/executor/ecs/ecs.go
@@ -254,7 +254,17 @@ func createPrimaryTaskSet(ctx context.Context, client provider.Client, service t
 	return nil
 }
 
-func sync(ctx context.Context, in *executor.Input, platformProviderName string, platformProviderCfg *config.PlatformProviderECSConfig, recreate bool, taskDefinition types.TaskDefinition, serviceDefinition types.Service, targetGroup *types.LoadBalancer, ignoreDesiredCountOnUpdate bool) bool {
+func sync(
+	ctx context.Context,
+	in *executor.Input,
+	platformProviderName string,
+	platformProviderCfg *config.PlatformProviderECSConfig,
+	recreate bool,
+	taskDefinition types.TaskDefinition,
+	serviceDefinition types.Service,
+	targetGroup *types.LoadBalancer,
+	ignoreDesiredCountOnUpdate bool,
+) bool {
 	client, err := provider.DefaultRegistry().Client(platformProviderName, platformProviderCfg, in.Logger)
 	if err != nil {
 		in.LogPersister.Errorf("Unable to create ECS client for the provider %s: %v", platformProviderName, err)

diff --git a/pkg/app/piped/executor/ecs/rollback.go b/pkg/app/piped/executor/ecs/rollback.go
@@ -95,7 +95,17 @@ func (e *rollbackExecutor) ensureRollback(ctx context.Context) model.StageStatus
 	return model.StageStatus_STAGE_SUCCESS
 }
 
-func rollback(ctx context.Context, in *executor.Input, platformProviderName string, platformProviderCfg *config.PlatformProviderECSConfig, taskDefinition types.TaskDefinition, serviceDefinition types.Service, primaryTargetGroup *types.LoadBalancer, canaryTargetGroup *types.LoadBalancer, ignoreDesiredCountOnUpdate bool) bool {
+func rollback(
+	ctx context.Context,
+	in *executor.Input,
+	platformProviderName string,
+	platformProviderCfg *config.PlatformProviderECSConfig,
+	taskDefinition types.TaskDefinition,
+	serviceDefinition types.Service,
+	primaryTargetGroup *types.LoadBalancer,
+	canaryTargetGroup *types.LoadBalancer,
+	ignoreDesiredCountOnUpdate bool,
+) bool {
 	in.LogPersister.Infof("Start rollback the ECS service and task family: %s and %s to original stage", *serviceDefinition.ServiceName, *taskDefinition.Family)
 	client, err := provider.DefaultRegistry().Client(platformProviderName, platformProviderCfg, in.Logger)
 	if err != nil {

diff --git a/pkg/config/application_ecs.go b/pkg/config/application_ecs.go
@@ -73,8 +73,7 @@ type ECSDeploymentInput struct {
 	//  - SERVICE_DISCOVERY -  The service is accessed via ECS Service Discovery.
 	// Default is ELB.
 	AccessType string `json:"accessType,omitempty" default:"ELB"`
-
-	// Whether to ignore desiredCount of the service definition when updating the service.
+	// Whether to ignore the desiredCount of the service definition when updating the service.
 	// If this is set as true, the desiredCount will be updated when creating the service, but will not be updated when updating the service.
 	// Default is false.
 	IgnoreDesiredCountOnUpdate *bool `json:"ignoreDesiredCountOnUpdate,omitempty" default:"false"`