fix tests: add a missing attribute

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
pipe-cd · Jul 8, 2024 · 7d65824 · 7d65824
1 parent dcd7dc9
commit 7d65824
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 16 deletions.
diff --git a/pkg/config/application_ecs_test.go b/pkg/config/application_ecs_test.go
@@ -65,10 +65,11 @@ func TestECSApplicationConfig(t *testing.T) {
 							ContainerPort:  80,
 						},
 					},
-					LaunchType:        "FARGATE",
-					AutoRollback:      newBoolPointer(true),
-					RunStandaloneTask: newBoolPointer(true),
-					AccessType:        "ELB",
+					LaunchType:                 "FARGATE",
+					AutoRollback:               newBoolPointer(true),
+					RunStandaloneTask:          newBoolPointer(true),
+					AccessType:                 "ELB",
+					IgnoreDesiredCountOnUpdate: newBoolPointer(true),
 				},
 			},
 			expectedError: nil,
@@ -97,12 +98,13 @@ func TestECSApplicationConfig(t *testing.T) {
 					},
 				},
 				Input: ECSDeploymentInput{
-					ServiceDefinitionFile: "/path/to/servicedef.yaml",
-					TaskDefinitionFile:    "/path/to/taskdef.yaml",
-					LaunchType:            "FARGATE",
-					AutoRollback:          newBoolPointer(true),
-					RunStandaloneTask:     newBoolPointer(true),
-					AccessType:            "SERVICE_DISCOVERY",
+					ServiceDefinitionFile:      "/path/to/servicedef.yaml",
+					TaskDefinitionFile:         "/path/to/taskdef.yaml",
+					LaunchType:                 "FARGATE",
+					AutoRollback:               newBoolPointer(true),
+					RunStandaloneTask:          newBoolPointer(true),
+					AccessType:                 "SERVICE_DISCOVERY",
+					IgnoreDesiredCountOnUpdate: newBoolPointer(false),
 				},
 			},
 			expectedError: nil,
@@ -131,12 +133,13 @@ func TestECSApplicationConfig(t *testing.T) {
 					},
 				},
 				Input: ECSDeploymentInput{
-					ServiceDefinitionFile: "/path/to/servicedef.yaml",
-					TaskDefinitionFile:    "/path/to/taskdef.yaml",
-					LaunchType:            "FARGATE",
-					AutoRollback:          newBoolPointer(true),
-					RunStandaloneTask:     newBoolPointer(true),
-					AccessType:            "XXX",
+					ServiceDefinitionFile:      "/path/to/servicedef.yaml",
+					TaskDefinitionFile:         "/path/to/taskdef.yaml",
+					LaunchType:                 "FARGATE",
+					AutoRollback:               newBoolPointer(true),
+					RunStandaloneTask:          newBoolPointer(true),
+					AccessType:                 "XXX",
+					IgnoreDesiredCountOnUpdate: newBoolPointer(false),
 				},
 			},
 			expectedError: fmt.Errorf("invalid accessType: XXX"),

diff --git a/pkg/config/testdata/application/ecs-app.yaml b/pkg/config/testdata/application/ecs-app.yaml
@@ -9,3 +9,4 @@ spec:
         targetGroupArn: arn:aws:elasticloadbalancing:xyz
         containerName: web
         containerPort: 80
+    ignoreDesiredCountOnUpdate: true