Add consts and validation of accessType

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

pkg/config/application_ecs.go

@@ -16,6 +16,12 @@ package config
 
 import (
 	"encoding/json"
+	"fmt"
+)
+
+const (
+	accessTypeELB              string = "ELB"
+	accessTypeServiveDiscovery string = "SERVICE_DISCOVERY"
 )
 
 // ECSApplicationSpec represents an application configuration for ECS application.
@@ -32,6 +38,11 @@ func (s *ECSApplicationSpec) Validate() error {
 	if err := s.GenericApplicationSpec.Validate(); err != nil {
 		return err
 	}
+
+	if err := s.Input.validateAccessType(); err != nil {
+		return err
+	}
+
 	return nil
 }
 
@@ -70,7 +81,7 @@ func (in *ECSDeploymentInput) IsStandaloneTask() bool {
 }
 
 func (in *ECSDeploymentInput) IsAccessedViaELB() bool {
-	return in.AccessType == "ELB"
+	return in.AccessType == accessTypeELB
 }
 
 type ECSVpcConfiguration struct {
@@ -131,3 +142,12 @@ func (opts ECSTrafficRoutingStageOptions) Percentage() (primary, canary int) {
 	canary = 0
 	return
 }
+
+func (in *ECSDeploymentInput) validateAccessType() error {
+	switch in.AccessType {
+	case accessTypeELB, accessTypeServiveDiscovery:
+		return nil
+	default:
+		return fmt.Errorf("invalid accessType: %s", in.AccessType)
+	}
+}

pkg/config/application_ecs_test.go

@@ -16,6 +16,7 @@ package config
 
 import (
 	"encoding/json"
+	"fmt"
 	"testing"
 	"time"
 
@@ -103,6 +104,40 @@ func TestECSApplicationConfig(t *testing.T) {
 			},
 			expectedError: nil,
 		},
+		{
+			fileName:           "testdata/application/ecs-app-invalid-access-type.yaml",
+			expectedKind:       KindECSApp,
+			expectedAPIVersion: "pipecd.dev/v1beta1",
+			expectedSpec: &ECSApplicationSpec{
+				GenericApplicationSpec: GenericApplicationSpec{
+					Timeout: Duration(6 * time.Hour),
+					Trigger: Trigger{
+						OnCommit: OnCommit{
+							Disabled: false,
+						},
+						OnCommand: OnCommand{
+							Disabled: false,
+						},
+						OnOutOfSync: OnOutOfSync{
+							Disabled:  newBoolPointer(true),
+							MinWindow: Duration(5 * time.Minute),
+						},
+						OnChain: OnChain{
+							Disabled: newBoolPointer(true),
+						},
+					},
+				},
+				Input: ECSDeploymentInput{
+					ServiceDefinitionFile: "/path/to/servicedef.yaml",
+					TaskDefinitionFile:    "/path/to/taskdef.yaml",
+					LaunchType:            "FARGATE",
+					AutoRollback:          newBoolPointer(true),
+					RunStandaloneTask:     newBoolPointer(true),
+					AccessType:            "XXX",
+				},
+			},
+			expectedError: fmt.Errorf("invalid accessType: XXX"),
+		},
 	}
 	for _, tc := range testcases {
 		t.Run(tc.fileName, func(t *testing.T) {

pkg/config/testdata/application/ecs-app-invalid-access-type.yaml

@@ -0,0 +1,7 @@
+apiVersion: pipecd.dev/v1beta1
+kind: ECSApp
+spec:
+  input:
+    serviceDefinitionFile: /path/to/servicedef.yaml
+    taskDefinitionFile: /path/to/taskdef.yaml
+    accessType: XXX