Skip to content

Commit

Permalink
fix: review point
Browse files Browse the repository at this point in the history
Signed-off-by: sivchari <shibuuuu5@gmail.com>
  • Loading branch information
sivchari committed Aug 18, 2023
1 parent ac2b825 commit ae05b63
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ description: >
## Kubernetes Application

``` yaml
apiVersion: pipecd.devI mean instead of adding it here, only make the vpc configuration available via Function manifest file. I think we should keep this configuration file contains generic configurations only./v1beta1
apiVersion: pipecd.dev/v1beta1
kind: KubernetesApp
spec:
input:
Expand Down
8 changes: 4 additions & 4 deletions pkg/app/piped/platformprovider/lambda/function_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,10 @@ func TestParseFunctionManifest(t *testing.T) {
"memory": 128,
"timeout": 5,
"image": "ecr.region.amazonaws.com/lambda-simple-function:v0.0.1",
"vpcConfig": {
securityGroupIds: ["sg-1234567890", "sg-0987654321"],
subnetIds: ["subnet-1234567890", "subnet-0987654321"]
}
"vpcConfig": {
securityGroupIds: ["sg-1234567890", "sg-0987654321"],
subnetIds: ["subnet-1234567890", "subnet-0987654321"]
}
}
}`,
wantSpec: FunctionManifest{
Expand Down

0 comments on commit ae05b63

Please sign in to comment.