Skip to content

Commit

Permalink
[ECS] Tag to the new taskset in rollback (fixes #4692) (#4695)
Browse files Browse the repository at this point in the history
* Tag to new taskset in rollback

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Fix #4692 (ECS excess tasksets)

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
  • Loading branch information
t-kikuc authored and khanhtc1202 committed Dec 1, 2023
1 parent faa5d8d commit b25053b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/app/piped/executor/ecs/rollback.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ func rollback(ctx context.Context, in *executor.Input, platformProviderName stri
return false
}

// Rollback ECS service configuration to previous state.
service, err := client.UpdateService(ctx, serviceDefinition)
// Rollback ECS service configuration to previous state including commit-hash of the tag.
service, err := applyServiceDefinition(ctx, client, serviceDefinition)
if err != nil {
in.LogPersister.Errorf("Unable to rollback ECS service %s configuration to previous stage: %v", *serviceDefinition.ServiceName, err)
return false
Expand Down

0 comments on commit b25053b

Please sign in to comment.