Use ModifyLister to modify the default rules

pipe-cd · Dec 21, 2023 · d79472e · d79472e
1 parent d51df79
commit d79472e
Showing 1 changed file with 17 additions and 6 deletions.
diff --git a/pkg/app/piped/platformprovider/ecs/client.go b/pkg/app/piped/platformprovider/ecs/client.go
@@ -472,12 +472,23 @@ func (c *client) ModifyListeners(ctx context.Context, listenerArns []string, rou
 				}
 			}
 
-			_, err := c.elbClient.ModifyRule(ctx, &elasticloadbalancingv2.ModifyRuleInput{
-				RuleArn: rule.RuleArn,
-				Actions: modifiedActions,
-			})
-			if err != nil {
-				return fmt.Errorf("failed to modify rule %s: %w", *rule.RuleArn, err)
+			// The default rule needs to be modified by ModifyListener API.
+			if rule.IsDefault {
+				_, err := c.elbClient.ModifyListener(ctx, &elasticloadbalancingv2.ModifyListenerInput{
+					ListenerArn:    &listenerArn,
+					DefaultActions: modifiedActions,
+				})
+				if err != nil {
+					return fmt.Errorf("failed to modify default rule %s: %w", *rule.RuleArn, err)
+				}
+			} else {
+				_, err := c.elbClient.ModifyRule(ctx, &elasticloadbalancingv2.ModifyRuleInput{
+					RuleArn: rule.RuleArn,
+					Actions: modifiedActions,
+				})
+				if err != nil {
+					return fmt.Errorf("failed to modify rule %s: %w", *rule.RuleArn, err)
+				}
 			}
 		}
 	}