fix: specify isRollback since deployment.Status is always Planned

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
pipe-cd · Dec 27, 2024 · df5a70c · df5a70c
1 parent b6faf9b
commit df5a70c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkg/app/piped/executor/kubernetes/rollback.go b/pkg/app/piped/executor/kubernetes/rollback.go
@@ -214,7 +214,7 @@ func (e *rollbackExecutor) ensureScriptRunRollback(ctx context.Context) model.St
 		}
 	}
 
-	ci := scriptrun.NewContextInfo(e.Deployment)
+	ci := scriptrun.NewContextInfo(e.Deployment, true)
 	ciEnv, err := ci.BuildEnv()
 	if err != nil {
 		e.LogPersister.Errorf("failed to build srcipt run context info: %w", err)

diff --git a/pkg/app/piped/executor/scriptrun/scriptrun.go b/pkg/app/piped/executor/scriptrun/scriptrun.go
@@ -101,7 +101,7 @@ func (e *Executor) executeCommand() model.StageStatus {
 		}
 	}
 
-	ci := NewContextInfo(e.Deployment)
+	ci := NewContextInfo(e.Deployment, false)
 	ciEnv, err := ci.BuildEnv()
 	if err != nil {
 		e.LogPersister.Errorf("failed to build srcipt run context info: %w", err)
@@ -144,7 +144,7 @@ type ContextInfo struct {
 }
 
 // NewContextInfo creates a new ContextInfo from the given deployment.
-func NewContextInfo(d *model.Deployment) *ContextInfo {
+func NewContextInfo(d *model.Deployment, isRollback bool) *ContextInfo {
 	return &ContextInfo{
 		DeploymentID:        d.Id,
 		ApplicationID:       d.ApplicationId,
@@ -155,7 +155,7 @@ func NewContextInfo(d *model.Deployment) *ContextInfo {
 		RepositoryURL:       d.GitPath.Repo.Remote,
 		Summary:             d.Summary,
 		Labels:              d.Labels,
-		IsRollback:          d.Status == model.DeploymentStatus_DEPLOYMENT_ROLLING_BACK,
+		IsRollback:          isRollback,
 	}
 }