feat(ECS): enable selection of listener rules #4540

moko-poi · 2023-08-07T09:57:42Z

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

How are users affected by this change:

apiVersion: pipecd.dev/v1beta1
kind: ECSApp
input:
  taskDefinitionFile: taskdef.yaml
  serviceDefinitionFile: servicedef.yaml
  targetGroups:
    primary:
    canary:

Is this breaking change: no
How to migrate (if breaking change):

codecov · 2023-08-07T23:46:38Z

Codecov Report

Attention: 99 lines in your changes are missing coverage. Please review.

Comparison is base (331b323) 30.01% compared to head (cd4f1a7) 29.94%.
Report is 68 commits behind head on master.

❗ Current head cd4f1a7 differs from pull request most recent head e91ab8a. Consider uploading reports for the commit e91ab8a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4540      +/-   ##
==========================================
- Coverage   30.01%   29.94%   -0.07%     
==========================================
  Files         220      221       +1     
  Lines       25761    25893     +132     
==========================================
+ Hits         7731     7754      +23     
- Misses      17385    17492     +107     
- Partials      645      647       +2

Files	Coverage Δ
...g/app/piped/platformprovider/ecs/listener_rules.go	`100.00% <100.00%> (ø)`
pkg/config/application_ecs.go	`9.52% <ø> (ø)`
pkg/config/application_kubernetes.go	`8.00% <ø> (ø)`
pkg/app/piped/platformprovider/ecs/ecs.go	`0.00% <0.00%> (ø)`
pkg/config/piped.go	`56.43% <37.50%> (+0.29%)`	⬆️
...g/app/piped/platformprovider/kubernetes/kubectl.go	`0.00% <0.00%> (ø)`
...g/app/piped/platformprovider/kubernetes/applier.go	`0.00% <0.00%> (ø)`
pkg/app/piped/platformprovider/ecs/client.go	`0.00% <0.00%> (ø)`

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kentakozuka

Thank you for the PR!
Can you update docs as well?

kentakozuka · 2023-08-08T01:40:12Z

pkg/app/piped/executor/ecs/ecs.go

-		in.LogPersister.Errorf("Failed to routing traffic to PRIMARY/CANARY variants: %v", err)
-		return false
+	if len(listenerRules) == 0 {
+		if err := client.ModifyListeners(ctx, currListenerArns, routingTrafficCfg); err != nil {


Move these lines inside this block because only this line references currListenerArns.

Thank you for the review, @kentakozuka!

I've made the suggested changes and moved the lines inside the block as per your feedback.
bb1b2f3

I've also updated the documentation to reflect the changes made in this PR.
9a2a9c0

Please let me know if there are any other points I should address.

kentakozuka

Thanks! LGTM 🎉
@khanhtc1202 Can you review for approval?

moko-poi · 2023-08-10T04:41:04Z

@kentakozuka @khanhtc1202
The CI has failed due to codecov/patch.

The coverage drop is due to missing test files. Adding tests might be beyond this PR's scope.
How should we address this?

Best regards,

khanhtc1202 · 2023-08-10T04:42:51Z

@moko-poi Don't worry about that. We can approve and ignore that 👌

khanhtc1202 · 2023-08-10T07:06:59Z

pkg/app/piped/executor/ecs/ecs.go

-	if err := client.ModifyListeners(ctx, currListenerArns, routingTrafficCfg); err != nil {
-		in.LogPersister.Errorf("Failed to routing traffic to PRIMARY/CANARY variants: %v", err)
-		return false
+	if len(listenerRules) == 0 {


@moko-poi let's make this easier to follow by removing the if/else condition here and return early (as pipecd code convention)
I think we can make it

if len(listenerRules) != 0 { // Do modify listener rules ... return true } // Do modify listener ... return true

@khanhtc1202
Thank you for the feedback.

I agree that following the pipecd code convention and using early returns will make the code clearer.
I refactored the if/else condition as you suggested and updated the PR.
29554b1

khanhtc1202 · 2023-08-11T06:15:17Z

@moko-poi Thanks so much for your contribution 🙏 There are 2 points that concern me in this current implementation.

First, not sure why we need to nest the configuration as listernerRules.rules, listernerRules directly contains rules make more sense to me.

apiVersion: pipecd.dev/v1beta1
kind: ECSApp
input:
  taskDefinitionFile: taskdef.yaml
  serviceDefinitionFile: servicedef.yaml
  targetGroups:
    primary:
    canary:
  listenerRules:
    - rule1
    - rule2

Second, as far as I understand, the current implementation (ref: code), piped can perform routing via

Updating rule (which forwarding canary/primary target group)
Updating listener (currently, clear all rules of the listener and only forwarding rule remained)

We currently don't have any way to validate the rules (set by users) are the rules which should be used to perform routing or not. That could lead to unexpected behavior if users miss setting the wrong rules to be used. Across the issue requirement, how about to keep finding current listeners of the given primary workload, then describe the listeners and find the forwarding rule to update, other rules will be remained and be included in the ModifyListener input?

We can use this API to describe specified listeners: https://docs.aws.amazon.com/cli/latest/reference/elbv2/describe-listeners.html

moko-poi · 2023-08-18T05:42:44Z

@khanhtc1202

Thank you for the feedback! I truly appreciate your insights.

Regarding the nesting of listenerRules.rules:You're absolutely right; having listenerRules directly contain the rules seems more intuitive.

I have now made the necessary modifications based on your suggestions. Please take a look at the updated implementation and let me know if there are any further changes or adjustments needed.
36440ca

In addition to the previous changes, I've also addressed the validation of provided listener rules against the existing rules. I'd appreciate it if you could review this new implementation as well. Thank you!
cd4f1a7

moko-poi · 2023-09-12T01:13:10Z

@kentakozuka @khanhtc1202
Thank you for the Public MTG the other day.

Based on the feedback received, I've decided not to add a new feature but to upgrade the existing functionality.

When you have a moment, I'd appreciate it if you could review the changes.

khanhtc1202 · 2023-10-31T10:46:13Z

@moko-poi Could you update the code to pass tests 👀

khanhtc1202 · 2023-10-31T10:54:27Z

pkg/app/piped/platformprovider/ecs/client.go

+func (c *client) GetListenerRuleArns(ctx context.Context, listenerArns []string) ([]string, error) {
+	var ruleArns []string
+
+	// 各リスナーのルールを取得


Please use comment in English

@khanhtc1202
Thank you for the feedback.
I'll make sure to use English in the comments moving forward.
d799ab0

moko-poi · 2023-11-01T01:48:58Z

@khanhtc1202
I've made the necessary updates to the code. Please take a look and let me know if there are any further changes needed. Thanks for the feedback!

khanhtc1202 · 2023-11-01T12:47:51Z

pkg/app/piped/platformprovider/ecs/client.go

+						Type: elbtypes.ActionTypeEnumForward,
+						ForwardConfig: &elbtypes.ForwardActionConfig{
+							TargetGroups: []elbtypes.TargetGroupTuple{
+								{
+									TargetGroupArn: aws.String(routingTrafficCfg[0].TargetGroupArn),
+									Weight:         aws.Int32(int32(routingTrafficCfg[0].Weight)),
+								},
+								{
+									TargetGroupArn: aws.String(routingTrafficCfg[1].TargetGroupArn),
+									Weight:         aws.Int32(int32(routingTrafficCfg[1].Weight)),
+								},


Will this always change a rule to ForwardAction type, which forwards traffic to primary/canary workload? if I recall correctly, we want to only modify the forward traffic actions, and keep "default forward 404" like action, isn't it?

Thank you for your review.

The code is designed to modify only the rules with 'forward' action types; all other rules will remain unchanged.

e91ab8a

@khanhtc1202

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

…sn't exist (pipe-cd#4504) * feat: add spec input.AutoCreateNamespace for creating a ns when doesn't exist Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * not return error when namespace already exists Signed-off-by: hungran <vmhung290791@gmail.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * not return err Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * WIP Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * omitempty AutoCreateNamespace, add test case Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * test data k8s-app-helm.yaml Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Redirect /docs/ to /docs-{latest}/ (pipe-cd#4495) * Redirect /docs/ to /docs-{latest}/ Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Fix use local path Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Fix documentation link is not displayed (pipe-cd#4505) Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update docs/content/en/docs-dev/user-guide/configuration-reference.md Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update pkg/config/application_kubernetes.go Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update pkg/config/application_kubernetes_test.go Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update pkg/config/application_test.go Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Bump word-wrap from 1.2.3 to 1.2.4 in /web (pipe-cd#4511) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Setup codecov (pipe-cd#4509) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add: caution note to user group doc (pipe-cd#4512) Signed-off-by: seitarof <pyotarou@icloud.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update go test command (pipe-cd#4514) * Update go test command Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Update makefile and github action command Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Revert gitignore Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Fix make release/docs command regenerate unused docs directory (pipe-cd#4513) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update auth docs (pipe-cd#4517) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Add Google Tag Manager to the site (pipe-cd#4519) * Add Google Tag Manager to the site Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add breakline Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add breakline Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update pkg/config/application_kubernetes_test.go Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update pkg/config/application_test.go Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update pkg/config/application_test.go Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update pkg/config/application_test.go Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update pkg/config/application_test.go Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * Update pkg/config/application_test.go Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * get value from var not from pointer Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * handle error when namespace already exsist and ignore it Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * rename handle err, remove unessacarry value test Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * if true Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * fix test data Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * fix correct the test case Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * remove unuse value in k8s-app-helm Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> --------- Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: hungran <vmhung290791@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: seitarof <pyotarou@icloud.com> Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Seitaro Fujigaki <51070449+seitarof@users.noreply.github.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

…dogConfig directly instead of reading files (pipe-cd#4518) * fix: optional setting apiKey and applicationKey for AnalysisProviderDatadogConfig directly Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * validate and error log Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add value test data Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add validate, base64decode for apiKeyData & applicationKeyData Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> --------- Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

* Add docs for PipeCD Terraform provider Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Fix page order Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

* Add blog entry of terraform-module-pipecd Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Fix path and sentence Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Update docs/content/en/blog/terraform-module-pipecd.md Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Update docs/content/en/blog/terraform-module-pipecd.md Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Update docs/content/en/blog/terraform-module-pipecd.md Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Update docs/content/en/blog/terraform-module-pipecd.md Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

) This reverts commit 824f9c0. Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

* Support singleton ECS task Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Rename singleton to recreate Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.17.0. - [Commits](golang/net@v0.8.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

pipe-cd#4612) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

…iew (pipe-cd#4611) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Signed-off-by: moko-poi <mokopoi44@gmail.com>

) * Fix lint/go errors (misspell) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (unconvert) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

…d#4622) * Fix lint/go errors (goimport) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (staticcheck) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix return error by function Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

…#4624) * Ignore mannwhitney from golangci-lint Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (deadcode) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

…t variable (pipe-cd#4628) * Add GOCACHE env to lint/go Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Add verbose flag to lint/go Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Change timeout golangci.yml Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

* Bump google.golang.org/grpc from 1.54.0 to 1.56.3 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.54.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.54.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update grpc test version Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

* Fix lint/go errors (stylecheck) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Remove nolint:stylecheck Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Change method reveiver name Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Change receiver name k to ak Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Signed-off-by: moko-poi <mokopoi44@gmail.com>

khanhtc1202 · 2023-11-09T15:51:18Z

Sorry for the late @moko-poi
The PR is containing changes that not related, please update so that we can merge 🙏

moko-poi · 2023-11-11T15:33:59Z

@kentakozuka @khanhtc1202
Closing this PR due to conflicts and delays. A new, updated PR has been created here: #4668. Please refer to the new PR for further discussion.

I apologize for any inconvenience and invite you to join the discussion on the new PR. Thank you for your understanding and collaboration.

github-actions bot added the area/go label Aug 7, 2023

moko-poi changed the title ~~feat: selection of listener rules~~ feat(ECS): enable selection of listener rules Aug 7, 2023

moko-poi marked this pull request as ready for review August 7, 2023 11:45

moko-poi requested review from nghialv, khanhtc1202 and kentakozuka as code owners August 7, 2023 11:45

kentakozuka reviewed Aug 8, 2023

View reviewed changes

kentakozuka reviewed Aug 9, 2023

View reviewed changes

moko-poi requested a review from kentakozuka August 10, 2023 00:54

khanhtc1202 reviewed Aug 10, 2023

View reviewed changes

moko-poi requested a review from khanhtc1202 August 10, 2023 09:32

moko-poi force-pushed the feat/selection-listener-rule-for-ecs branch from 394adbf to cd4f1a7 Compare August 18, 2023 05:54

khanhtc1202 requested a review from ffjlabo as a code owner October 30, 2023 09:04

khanhtc1202 reviewed Oct 31, 2023

View reviewed changes

khanhtc1202 reviewed Nov 1, 2023

View reviewed changes

khanhtc1202 and others added 7 commits November 3, 2023 11:44

Add goreport and codecov card to README (pipe-cd#4524)

31a1ad5

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Fix incorrect word module to provider in docs (pipe-cd#4532)

07c4470

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Revert "Add Google Tag Manager to the site (pipe-cd#4519)" (pipe-cd#4531

b3b1aaf

) This reverts commit 824f9c0. Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

ffjlabo and others added 20 commits November 3, 2023 11:44

Add ffjlabo to maintainer (pipe-cd#4607)

e7336e0

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Fix unable to rollout ECS first taskset (pipe-cd#4614)

b072174

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Bump @babel/traverse from 7.14.7 to 7.23.2 in /web (pipe-cd#4619)

dea31ce

Signed-off-by: moko-poi <mokopoi44@gmail.com>

Update contributors (pipe-cd#4623)

39bef2c

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Add tests to terraform platform provider (pipe-cd#4625)

2097e02

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Add tests to apikey model (pipe-cd#4626)

c2157b5

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Add tests to application model (pipe-cd#4627)

54c8c31

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

Add tests to model/deployment (pipe-cd#4629)

9a70e2c

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

fix: rollback

d00b73a

Signed-off-by: moko-poi <mokopoi44@gmail.com>

chore: remove ModifyListenerRules

99bb6f3

Signed-off-by: moko-poi <mokopoi44@gmail.com>

moko-poi force-pushed the feat/selection-listener-rule-for-ecs branch from 2f76fa8 to 99bb6f3 Compare November 3, 2023 02:44

github-actions bot added area/manifests area/web area/build area/tool labels Nov 3, 2023

feat: Modify only when action type is forward

e91ab8a

Signed-off-by: moko-poi <mokopoi44@gmail.com>

moko-poi mentioned this pull request Nov 11, 2023

feat(ECS): enable selection of listener rules #4668

Merged

moko-poi closed this Nov 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ECS): enable selection of listener rules #4540

feat(ECS): enable selection of listener rules #4540

moko-poi commented Aug 7, 2023 •

edited

Loading

codecov bot commented Aug 7, 2023 •

edited

Loading

kentakozuka left a comment

kentakozuka Aug 8, 2023

moko-poi Aug 9, 2023

kentakozuka left a comment

moko-poi commented Aug 10, 2023

khanhtc1202 commented Aug 10, 2023

khanhtc1202 Aug 10, 2023 •

edited

Loading

moko-poi Aug 10, 2023

khanhtc1202 commented Aug 11, 2023 •

edited

Loading

moko-poi commented Aug 18, 2023 •

edited

Loading

moko-poi commented Sep 12, 2023

khanhtc1202 commented Oct 31, 2023

khanhtc1202 Oct 31, 2023

moko-poi Nov 1, 2023

moko-poi commented Nov 1, 2023

khanhtc1202 Nov 1, 2023

moko-poi Nov 3, 2023

moko-poi Nov 3, 2023

khanhtc1202 commented Nov 9, 2023

moko-poi commented Nov 11, 2023

feat(ECS): enable selection of listener rules #4540

feat(ECS): enable selection of listener rules #4540

Conversation

moko-poi commented Aug 7, 2023 • edited Loading

codecov bot commented Aug 7, 2023 • edited Loading

Codecov Report

kentakozuka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kentakozuka left a comment

Choose a reason for hiding this comment

moko-poi commented Aug 10, 2023

khanhtc1202 commented Aug 10, 2023

khanhtc1202 Aug 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

khanhtc1202 commented Aug 11, 2023 • edited Loading

moko-poi commented Aug 18, 2023 • edited Loading

moko-poi commented Sep 12, 2023

khanhtc1202 commented Oct 31, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moko-poi commented Nov 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

khanhtc1202 commented Nov 9, 2023

moko-poi commented Nov 11, 2023

moko-poi commented Aug 7, 2023 •

edited

Loading

codecov bot commented Aug 7, 2023 •

edited

Loading

khanhtc1202 Aug 10, 2023 •

edited

Loading

khanhtc1202 commented Aug 11, 2023 •

edited

Loading

moko-poi commented Aug 18, 2023 •

edited

Loading