add qemu and buildx for multi arch (arm64) #4552

hungran · 2023-08-18T16:23:49Z

What this PR does / why we need it: ARM64 for piped and pipecd
I was tried from my local environment which using docker buildx to build linux/arm64 for only Piped and PipeCD image, and quick setup with helm pipecd and piped seem ok
not sure with piped-okd and launcher
Which issue(s) this PR fixes:

Fixes ##4544

Does this PR introduce a user-facing change?: N/A

How are users affected by this change: User might have option to run PipeCD and PipeD on arm64 node
Is this breaking change: No
How to migrate (if breaking change): N/A

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

hungran · 2023-08-18T16:29:57Z

.github/workflows/publish_image_chart.yaml

@@ -54,6 +54,12 @@ jobs:
      - name: Build web static
        run: make build/web

+      # Setup QEMU and Buildx.      
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@8b122486cedac8393e77aa9734c3528886e4a1a8 #v2.0.0


Action QEMU v2.0.0 is using node16
docker/setup-qemu-action#48

hungran · 2023-08-18T16:24:37Z

.github/workflows/publish_image_chart.yaml

+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@8b122486cedac8393e77aa9734c3528886e4a1a8 #v2.0.0
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@dc7b9719a96d48369863986a06765841d7ea23f6 #2.0.0


same as above

hungran · 2023-08-18T16:29:57Z

.github/workflows/publish_image_chart.yaml

@@ -54,6 +54,12 @@ jobs:
      - name: Build web static
        run: make build/web

+      # Setup QEMU and Buildx.      
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@8b122486cedac8393e77aa9734c3528886e4a1a8 #v2.0.0


Action QEMU v2.0.0 is using node16
docker/setup-qemu-action#48

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

codecov · 2023-08-19T05:20:17Z

Codecov Report

Patch coverage has no change and project coverage change: +0.03% 🎉

Comparison is base (801a7c6) 29.91% compared to head (692b6d8) 29.95%.
Report is 3 commits behind head on master.

❗ Current head 692b6d8 differs from pull request most recent head c2e31de. Consider uploading reports for the commit c2e31de to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4552      +/-   ##
==========================================
+ Coverage   29.91%   29.95%   +0.03%     
==========================================
  Files         220      220              
  Lines       25873    25872       -1     
==========================================
+ Hits         7741     7749       +8     
+ Misses      17484    17476       -8     
+ Partials      648      647       -1

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hungran · 2023-08-19T13:17:10Z

Launcher included!!!

kentakozuka

What about these images?

piped-okd
launcher-okd
pipectl
helloworld

kentakozuka · 2023-08-23T00:00:27Z

.github/workflows/publish_image_chart.yaml

          tags: ${{ env.GHCR }}/pipe-cd/pipecd:${{ env.PIPECD_VERSION }}
+


Remove an empty line.

kentakozuka · 2023-08-23T00:00:33Z

.github/workflows/publish_image_chart.yaml

          tags: |
            ${{ env.GHCR }}/pipe-cd/piped:${{ env.PIPECD_VERSION }}
            ${{ env.GCR }}/pipecd/piped:${{ env.PIPECD_VERSION }}
+


Remove an empty line.

hungran · 2023-08-23T09:54:50Z

@kentakozuka thanks for your feedback
I could understand with pipectl and helloworld
I have same question too for the remain (...okd) @khanhtc1202

khanhtc1202 · 2023-08-23T10:08:01Z

All xxx-okd are for the openshift on-premise environment, so maybe someone want that on arm64 nodes as well, so let's support that too 👍

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

hungran · 2023-08-24T16:24:57Z

@kentakozuka @khanhtc1202
thanks for your support
added

khanhtc1202

LGreatTM 🙌

* add qemu and buildx for multi arch (arm64) Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add launcher multiple platform Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add okd, helloworld and pipectl arm64 Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> --------- Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: 徳田真之介 <tokuda_shinnosuke@cyberagent.co.jp>

* add qemu and buildx for multi arch (arm64) Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add launcher multiple platform Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add okd, helloworld and pipectl arm64 Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> --------- Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>

add qemu and buildx for multi arch (arm64)

86b9a4d

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

hungran requested review from nghialv, khanhtc1202 and kentakozuka as code owners August 18, 2023 16:23

github-actions bot added the area/build label Aug 18, 2023

hungran commented Aug 18, 2023

View reviewed changes

add launcher multiple platform

0dca372

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

kentakozuka reviewed Aug 23, 2023

View reviewed changes

Merge branch 'master' into hungran/arm64

692b6d8

hungran added 2 commits August 24, 2023 13:27

Merge branch 'master' into hungran/arm64

16691f5

add okd, helloworld and pipectl arm64

c2e31de

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

hungran requested a review from kentakozuka August 24, 2023 16:28

khanhtc1202 approved these changes Aug 25, 2023

View reviewed changes

khanhtc1202 merged commit 9f75446 into pipe-cd:master Aug 25, 2023
11 checks passed

hungran mentioned this pull request Aug 25, 2023

Support container images for the ARM64 architecture #4544

Closed

github-actions bot mentioned this pull request Dec 1, 2023

Release v0.45.4 #4697

Merged

github-actions bot mentioned this pull request Feb 6, 2024

Release v0.46.0 #4775

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add qemu and buildx for multi arch (arm64) #4552

add qemu and buildx for multi arch (arm64) #4552

hungran commented Aug 18, 2023 •

edited

Loading

hungran Aug 18, 2023 •

edited

Loading

hungran Aug 18, 2023

hungran Aug 18, 2023 •

edited

Loading

codecov bot commented Aug 19, 2023 •

edited

Loading

hungran commented Aug 19, 2023 •

edited

Loading

kentakozuka left a comment

kentakozuka Aug 23, 2023

kentakozuka Aug 23, 2023

hungran commented Aug 23, 2023

khanhtc1202 commented Aug 23, 2023

hungran commented Aug 24, 2023

khanhtc1202 left a comment

		tags: ${{ env.GHCR }}/pipe-cd/pipecd:${{ env.PIPECD_VERSION }}

add qemu and buildx for multi arch (arm64) #4552

add qemu and buildx for multi arch (arm64) #4552

Conversation

hungran commented Aug 18, 2023 • edited Loading

hungran Aug 18, 2023 • edited Loading

Choose a reason for hiding this comment

hungran Aug 18, 2023

Choose a reason for hiding this comment

hungran Aug 18, 2023 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Aug 19, 2023 • edited Loading

Codecov Report

hungran commented Aug 19, 2023 • edited Loading

kentakozuka left a comment

Choose a reason for hiding this comment

kentakozuka Aug 23, 2023

Choose a reason for hiding this comment

kentakozuka Aug 23, 2023

Choose a reason for hiding this comment

hungran commented Aug 23, 2023

khanhtc1202 commented Aug 23, 2023

hungran commented Aug 24, 2023

khanhtc1202 left a comment

Choose a reason for hiding this comment

hungran commented Aug 18, 2023 •

edited

Loading

hungran Aug 18, 2023 •

edited

Loading

hungran Aug 18, 2023 •

edited

Loading

codecov bot commented Aug 19, 2023 •

edited

Loading

hungran commented Aug 19, 2023 •

edited

Loading