Fix unable to fetch ECS taskset tags #4605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4605 +/- ##
==========================================
- Coverage 30.02% 30.00% -0.03%
==========================================
Files 221 221
Lines 25937 25955 +18
==========================================
Hits 7787 7787
- Misses 17501 17519 +18
Partials 649 649
☔ View full report in Codecov by Sentry. |
nghialv
approved these changes
Oct 6, 2023
khanhtc1202
added a commit
that referenced
this pull request
Oct 11, 2023
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
added a commit
that referenced
this pull request
Oct 11, 2023
* Display MySQL user defined error in API Key UI (#4590) * Display MySQL user defined error in UI Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Fix Unexpected empty arrow function Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Run subtests in parallel Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Display MySQL user defined error of piped, command, and application (#4597) Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add service tags as takset task on create (#4598) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * [ECS] Fix remove all previous active tasksets on QuickSync (#4600) * Remove previous ACTIVE tasksets if present on quicksync Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Remove GetPrimaryTaskSet interface Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Fix unable to fetch ECS taskset tags (#4605) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Support recreate for ECS tasks (#4608) * Support singleton ECS task Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Rename singleton to recreate Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com>
moko-poi
pushed a commit
to moko-poi/pipecd
that referenced
this pull request
Nov 3, 2023
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Nov 5, 2023
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The current implementation of fetching ECS taskset is wrong because ECS describe-services API does not return tasksets' TAGS. We have to use the ECS describe-task-sets with
--includes TAGSoption to get those tags for filtering logic.refer: https://docs.aws.amazon.com/cli/latest/reference/ecs/describe-task-sets.html
Which issue(s) this PR fixes:
Follow #4600
Does this PR introduce a user-facing change?: