Fix panic error in ListDeployments API #4650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seitarof <pyotarou@icloud.com>
seitarof
requested review from
nghialv,
khanhtc1202,
kentakozuka and
ffjlabo
as code owners
ffjlabo
pushed a commit
that referenced
this pull request
Nov 13, 2023
khanhtc1202
added a commit
that referenced
this pull request
Nov 13, 2023
#4628 #4629 #4631 #4632 #4633 #4637 #4638 #4641 #4648 #4650 #4656 #4658 #4662 #4666 (#4669) * Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-plan-preview (#4611) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-gh-release (#4612) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> * Bump golang.org/x/net from 0.8.0 to 0.17.0 (#4613) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.17.0. - [Commits](golang/net@v0.8.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/traverse from 7.14.7 to 7.23.2 in /web (#4619) * Fix part of lint/go errors (misspell, depguard, unconvert) (#4621) * Fix lint/go errors (misspell) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (unconvert) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix part of lint/go errors (goimports, staticcheck, gosimple) (#4622) * Fix lint/go errors (goimport) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (staticcheck) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix return error by function Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix part of lint/go errors (deadcode, ineffassign, depguard) (#4624) * Ignore mannwhitney from golangci-lint Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (deadcode) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Add tests to terraform platform provider (#4625) Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests to apikey model (#4626) Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests to application model (#4627) Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Reduce `make lint/go` execution time by adding the GOCACHE environment variable (#4628) * Add GOCACHE env to lint/go Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Add verbose flag to lint/go Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Change timeout golangci.yml Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Add tests to model/deployment (#4629) Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add Parallel() Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests to model/deployment_chain (#4632) * Bump google.golang.org/grpc from 1.54.0 to 1.56.3 (#4633) * Bump google.golang.org/grpc from 1.54.0 to 1.56.3 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.54.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.54.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update grpc test version Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: khanhtc1202 <khanhtc1202@gmail.com> * Fix lint/go errors (gocritic) (#4637) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix part of lint/go errors (stylecheck) (#4638) * Fix lint/go errors (stylecheck) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Remove nolint:stylecheck Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Change method reveiver name Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Change receiver name k to ak Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Bump github.com/docker/docker (#4641) * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <mi11km.program@gmail.com> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <mi11km.program@gmail.com> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add Parallel() Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: mi11km <mi11km.program@gmail.com> * add piped-handle-timeout(input args) Signed-off-by: mi11km <mi11km.program@gmail.com> --------- Signed-off-by: mi11km <mi11km.program@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> * Fix panic error in ListDeployments API (#4650) * Update golangci-lint and fix lint errors (#4656) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Send error comment before plan preview exit (#4658) * Send error comment before plan preview exit Signed-off-by: Takumaron <tennis.takumax@gmail.com> * Apply review commnet Signed-off-by: Takumaron <tennis.takumax@gmail.com> --------- Signed-off-by: Takumaron <tennis.takumax@gmail.com> * Handle plan preview workflow's error and exit with error status code (#4662) * Add a flag to skip running standalone task during deployment (#4666) * Add a flag to skip running standalone task during deployment Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Fix docs Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: mi11km <mi11km.program@gmail.com> Signed-off-by: Takumaron <tennis.takumax@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: karamaru <38310693+karamaru-alpha@users.noreply.github.com> Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: Masafumi Ikeyama <54844746+mi11km@users.noreply.github.com> Co-authored-by: Seitaro Fujigaki <51070449+seitarof@users.noreply.github.com> Co-authored-by: Kurosawa Takuma <tennis.takumax@gmail.com>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Feb 12, 2024
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3443
Does this PR introduce a user-facing change?: