add ephemeralStorage option to lambda config #4680

nnnkkk7 · 2023-11-19T06:38:49Z

What this PR does / why we need it:
I added an ephemeralStorage optional value to the lambda configuration.

Which issue(s) this PR fixes:

Fixes #4679

Does this PR introduce a user-facing change?:
No

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>

khanhtc1202 · 2023-11-21T10:11:19Z

pkg/app/piped/platformprovider/lambda/client.go

@@ -278,6 +281,9 @@ func (c *client) updateFunctionConfiguration(ctx context.Context, fm FunctionMan
 		if fm.Spec.Handler != "" {
 			configInput.Handler = aws.String(fm.Spec.Handler)
 		}
+		if fm.Spec.EphemeralStorage.Size != 0 {


Suggested change

if fm.Spec.EphemeralStorage.Size != 0 {

if fm.Spec.EphemeralStorage != nil && fm.Spec.EphemeralStorage.Size != 0 {

avoid nil pointer error due to the omitempty json tag

Thank you! I added it.
add nil pointer check

khanhtc1202 · 2023-11-21T10:16:35Z

@nnnkkk7 Thanks for the contribution. For this configuration, should we also add this to CreateFunctionXXX step as well? I mean the following 2 places
https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/platformprovider/lambda/client.go#L111
https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/platformprovider/lambda/client.go#L160

Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>

nnnkkk7 · 2023-11-21T23:58:01Z

@khanhtc1202
Thanks! I had forgot to add this configuration to CreateFunctionFromSource!
add EphemeralStorage input to CreateFunctionFromSource

khanhtc1202 · 2023-11-23T10:54:57Z

pkg/app/piped/platformprovider/lambda/function.go

@@ -100,6 +103,11 @@ func (fmp FunctionManifestSpec) validate() error {
 			return fmt.Errorf("architecture is invalid: %w", err)
 		}
 	}
+	if fmp.EphemeralStorage != nil && fmp.EphemeralStorage.Size != 0 {


This condition is wrong 🤔 If the size value is set to 0 the validate function will be bypass.

Suggested change

if fmp.EphemeralStorage != nil && fmp.EphemeralStorage.Size != 0 {

if fmp.EphemeralStorage != nil {

Thank you!
I fixed these conditions! fix condition

pkg/app/piped/platformprovider/lambda/client.go

Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>

khanhtc1202

LGTM, thank you 🎸

codecov · 2023-11-27T10:07:06Z

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (8a4235b) 30.82% compared to head (8af45bb) 30.84%.
Report is 2 commits behind head on master.

Files	Patch %	Lines
pkg/app/piped/platformprovider/lambda/client.go	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4680      +/-   ##
==========================================
+ Coverage   30.82%   30.84%   +0.01%     
==========================================
  Files         221      221              
  Lines       25935    25952      +17     
==========================================
+ Hits         7995     8004       +9     
- Misses      17289    17298       +9     
+ Partials      651      650       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * add nil pointer check Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * fix condition Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> --------- Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>

* add ephemeralStorage option to lambda config (#4680) * add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * add nil pointer check Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * fix condition Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> --------- Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * Add v2 to versionWhitelist (#4682) Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * [ECS] Tag to the new taskset in rollback (fixes #4692) (#4695) * Tag to new taskset in rollback Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix #4692 (ECS excess tasksets) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Co-authored-by: naoki kuroda <68233204+nnnkkk7@users.noreply.github.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>

* add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * add nil pointer check Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * fix condition Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> --------- Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>

* add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * add nil pointer check Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * fix condition Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> --------- Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * add nil pointer check Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> * fix condition Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> --------- Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> Signed-off-by: 鈴木優耀 <suzuki_masaaki@cyberagent.co.jp>

nnnkkk7 requested review from nghialv, khanhtc1202, kentakozuka and ffjlabo as code owners November 19, 2023 06:38

github-actions bot added the area/go label Nov 19, 2023

nnnkkk7 mentioned this pull request Nov 19, 2023

support ephemeralStorage optional filed for lambda #4679

Closed

add ephemeralStorage option to lambda config

38791cf

Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>

nnnkkk7 force-pushed the add-ephemeralStorage-option-to-lambda branch from 1784872 to 38791cf Compare November 19, 2023 06:42

khanhtc1202 reviewed Nov 21, 2023

View reviewed changes

nnnkkk7 added 2 commits November 22, 2023 08:47

add nil pointer check

caf1321

Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>

add EphemeralStorage input to CreateFunctionFromSource

639d0f4

Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>

nnnkkk7 requested a review from khanhtc1202 November 21, 2023 23:58

khanhtc1202 reviewed Nov 23, 2023

View reviewed changes

pkg/app/piped/platformprovider/lambda/client.go Outdated Show resolved Hide resolved

khanhtc1202 reviewed Nov 23, 2023

View reviewed changes

pkg/app/piped/platformprovider/lambda/client.go Outdated Show resolved Hide resolved

khanhtc1202 reviewed Nov 23, 2023

View reviewed changes

pkg/app/piped/platformprovider/lambda/client.go Outdated Show resolved Hide resolved

fix condition

8af45bb

Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>

nnnkkk7 requested a review from khanhtc1202 November 24, 2023 00:53

khanhtc1202 approved these changes Nov 27, 2023

View reviewed changes

khanhtc1202 merged commit f10a8e7 into pipe-cd:master Nov 27, 2023
13 checks passed

github-actions bot mentioned this pull request Dec 1, 2023

Release v0.45.4 #4697

Merged

khanhtc1202 mentioned this pull request Dec 1, 2023

Cherry-pick #4680 #4682 #4695 #4698

Merged

github-actions bot mentioned this pull request Feb 6, 2024

Release v0.46.0 #4775

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add ephemeralStorage option to lambda config #4680

add ephemeralStorage option to lambda config #4680

nnnkkk7 commented Nov 19, 2023

khanhtc1202 Nov 21, 2023

nnnkkk7 Nov 21, 2023

khanhtc1202 commented Nov 21, 2023

nnnkkk7 commented Nov 21, 2023 •

edited

Loading

khanhtc1202 Nov 23, 2023

nnnkkk7 Nov 24, 2023

khanhtc1202 left a comment

codecov bot commented Nov 27, 2023

	if fm.Spec.EphemeralStorage.Size != 0 {
	if fm.Spec.EphemeralStorage != nil && fm.Spec.EphemeralStorage.Size != 0 {

	if fmp.EphemeralStorage != nil && fmp.EphemeralStorage.Size != 0 {
	if fmp.EphemeralStorage != nil {

add ephemeralStorage option to lambda config #4680

add ephemeralStorage option to lambda config #4680

Conversation

nnnkkk7 commented Nov 19, 2023

khanhtc1202 Nov 21, 2023

Choose a reason for hiding this comment

nnnkkk7 Nov 21, 2023

Choose a reason for hiding this comment

khanhtc1202 commented Nov 21, 2023

nnnkkk7 commented Nov 21, 2023 • edited Loading

khanhtc1202 Nov 23, 2023

Choose a reason for hiding this comment

nnnkkk7 Nov 24, 2023

Choose a reason for hiding this comment

khanhtc1202 left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 27, 2023

Codecov Report

nnnkkk7 commented Nov 21, 2023 •

edited

Loading