Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event name typos on notification docs #4706

Merged

Conversation

minhquang4334
Copy link
Contributor

@minhquang4334 minhquang4334 commented Dec 6, 2023

What this PR does / why we need it:
Found a event name typos on notification docs. Fix event name from DEPLOYMENT_COMPLETED to DEPLOYMENT_SUCCEEDED.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: minhquang4334 <minhquang4334@gmail.com>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you 🙌

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) December 7, 2023 01:05
@khanhtc1202 khanhtc1202 merged commit 5cdf2b8 into pipe-cd:master Dec 7, 2023
11 checks passed
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Feb 12, 2024
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants