Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark CUSTOM_SYNC as deprecated feature #4740

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Mark CUSTOM_SYNC as deprecated feature #4740

merged 1 commit into from
Dec 26, 2023

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) December 26, 2023 07:18
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cbcef3) 30.80% compared to head (7b5f8bf) 30.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4740   +/-   ##
=======================================
  Coverage   30.80%   30.81%           
=======================================
  Files         221      221           
  Lines       26015    26015           
=======================================
+ Hits         8015     8017    +2     
+ Misses      17349    17348    -1     
+ Partials      651      650    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 🚀

@khanhtc1202 khanhtc1202 merged commit c38b37b into master Dec 26, 2023
14 checks passed
@khanhtc1202 khanhtc1202 deleted the update-docs branch December 26, 2023 07:30
nnnkkk7 pushed a commit to nnnkkk7/pipecd that referenced this pull request Feb 1, 2024
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants