Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECS] Support Plan Preview for ECS #4881

Merged
merged 40 commits into from
Apr 30, 2024
Merged

[ECS] Support Plan Preview for ECS #4881

merged 40 commits into from
Apr 30, 2024

Commits on Apr 8, 2024

  1. Impl ECS's Diff func of taskDef and serviceDef 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    42aa504 View commit details
    Browse the repository at this point in the history

  2. Add ECSManifest's cache 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    52d89e9 View commit details
    Browse the repository at this point in the history

  3. Impl ECSDiff for planpreview 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    841459b View commit details
    Browse the repository at this point in the history

  4. Enable ECS PlanPreview 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8c2157d View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Draft: diff test 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    f99bebe View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Add and fix tests of diff with TODO of lowerCamelCase 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8190daa View commit details
    Browse the repository at this point in the history

  2. fix tests: add params to servicedef 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    98b740b View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Remove wip comments 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    43d3ff8 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Skip summarizing if no changes were detected 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b416577 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Add tags to test data 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5f4f2b9 View commit details
    Browse the repository at this point in the history

  2. removed an unnecessary test case 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    46cff87 View commit details
    Browse the repository at this point in the history

  3. Clean comments, removing TODO 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5325c36 View commit details
    Browse the repository at this point in the history

  4. remove an unnecessary blank line in the test data 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0b33d5a View commit details
    Browse the repository at this point in the history

  5. Modify ApiVersion and Kind to apparent dummy 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    00c9dd8 View commit details
    Browse the repository at this point in the history

  6. Add DiffStructs() for comparing non-k8s manifests 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c9f2975 View commit details
    Browse the repository at this point in the history

  7. removed unstructured.Unstructured from ECS 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    7613dd5 View commit details
    Browse the repository at this point in the history

  8. Separate DiffByCommand() to diff package 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    17b8dfe View commit details
    Browse the repository at this point in the history

  9. Fix diff render output: split ServiceDef and TaskDef sections 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    6b07291 View commit details
    Browse the repository at this point in the history

  10. Add a testcase to planpreview_test for ECS 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9ff2fcf View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge branch 'master' into ecs-plan-preview

    @khanhtc1202
    khanhtc1202 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    323b4bb View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Combine unnecessary DiffBytesByCommand() to DiffByCommand() 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b174d23 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ecs-plan-preview' of https://github.com/pipe-cd/pipecd … 

    …into ecs-plan-preview

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e2a38f0 View commit details
    Browse the repository at this point in the history

  3. Remove IgnorePath from comparing ECS Manifests 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    dd40abb View commit details
    Browse the repository at this point in the history

  4. rename func to DiffStructureds() 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    59f3171 View commit details
    Browse the repository at this point in the history

  5. add comment of which func to use 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    77dcef7 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Removed LoadECSManifest() func 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9279185 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Rename test func 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    db54c29 View commit details
    Browse the repository at this point in the history

  2. Add tests of diffbycommand 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    eca1b74 View commit details
    Browse the repository at this point in the history

  3. Removed duplicated tests 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    46233d0 View commit details
    Browse the repository at this point in the history

  4. Rename ECSManifest to ECSManifests 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    97405b4 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into ecs-plan-preview

    @t-kikuc
    t-kikuc committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    33fdec1 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Removed an unnecessary variable 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3fee826 View commit details
    Browse the repository at this point in the history

  2. Renamed func to 'renderByCommand' 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0cb5d29 View commit details
    Browse the repository at this point in the history

  3. Add check of existence of the command 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c9764e4 View commit details
    Browse the repository at this point in the history

  4. Rename func to 'RenderByCommand' 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    55b89b6 View commit details
    Browse the repository at this point in the history

  5. Moved func 'RenderByCommand()' to renderer.go 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c38c07b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'ecs-plan-preview' of https://github.com/pipe-cd/pipecd … 

    …into ecs-plan-preview

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6f542c6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into ecs-plan-preview

    @t-kikuc
    t-kikuc committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e252b8d View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Fix nits: removed unnecessary if-state 

    Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    64efe0a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ecs-plan-preview' of https://github.com/pipe-cd/pipecd … 

    …into ecs-plan-preview

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
    @t-kikuc
    t-kikuc committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a161cba View commit details
    Browse the repository at this point in the history