Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to add -n opiton for echo #4913

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix to add -n opiton for echo #4913

merged 1 commit into from
May 14, 2024

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented May 14, 2024

What this PR does / why we need it:

Added -n option to avoid the unexpected base64 encoded value.
The echo command adds \n at the end of the output by default. We can remove it by adding the option -n.

DESCRIPTION
     The echo utility writes any specified operands, separated by single blank (‘ ') characters and followed by a
     newline ('\n') character, to the standard output.
     -n    Do not print the trailing newline character.  This may also be achieved by appending ‘\c’ to the end of the
           string, as is done by iBCS2 compatible systems.  Note that this option as well as the effect of ‘\c’ are
           implementation-defined in IEEE Std 1003.1-2001 (“POSIX.1”) as amended by Cor. 1-2002.  Applications aiming
           for maximum portability are strongly encouraged to use printf(1) to suppress the newline character.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.30%. Comparing base (340b6df) to head (e2be37c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4913      +/-   ##
==========================================
- Coverage   29.32%   29.30%   -0.02%     
==========================================
  Files         321      321              
  Lines       40835    40835              
==========================================
- Hits        11974    11968       -6     
- Misses      27904    27910       +6     
  Partials      957      957              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@ffjlabo ffjlabo merged commit 1258b55 into master May 14, 2024
13 of 14 checks passed
@ffjlabo ffjlabo deleted the fix-docs-for-piped-readme branch May 14, 2024 09:08
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants