Pass the DeploySource directly to the plugin #5050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5050 +/- ##
==========================================
+ Coverage 22.45% 22.48% +0.02%
==========================================
Files 522 522
Lines 57026 57007 -19
==========================================
+ Hits 12807 12818 +11
+ Misses 43192 43161 -31
- Partials 1027 1028 +1 ☔ View full report in Codecov by Sentry. |
khanhtc1202
reviewed
Jul 17, 2024
khanhtc1202
reviewed
Jul 17, 2024
Comment on lines
+79
to
+82
| // The source of the deployment. | ||
| DeploySource deploy_source = 3; | ||
| // The source of the last successful deployment. | ||
| DeploySource last_successful_deploy_source = 4; |
There was a problem hiding this comment.
Suggested change
| // The source of the deployment. | |
| DeploySource deploy_source = 3; | |
| // The source of the last successful deployment. | |
| DeploySource last_successful_deploy_source = 4; | |
| // The source of the target state. | |
| DeploySource target_deploy_source = 3; | |
| // The source of the running state. | |
| DeploySource running_deploy_source = 4; |
How about renaming like this 👀
|
I have not been able to work on this PR for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR modifies the plugin input.
The piped passes the deploy source information directly to the plugin, and the plugin expects the piped to prepare the deploy source before invoking the RPC methods.
The application spec is defined in bytes because we don't want to define the spec's structure for each plugin.
This PR does not touch the deploysource package because it's widely used, and the type
DeploySourceis not only used in the pipedv1 but also in other packages.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: