Pipedv1 using auto rollback config from spec.Planner instead #5052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
requested review from
nghialv,
kentakozuka,
ffjlabo,
t-kikuc and
Warashi
as code owners
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5052 +/- ##
==========================================
- Coverage 22.75% 22.74% -0.01%
==========================================
Files 406 406
Lines 43041 43041
==========================================
- Hits 9794 9790 -4
- Misses 32470 32473 +3
- Partials 777 778 +1 ☔ View full report in Codecov by Sentry. |
t-kikuc
previously approved these changes
Jul 18, 2024
ffjlabo
reviewed
Jul 18, 2024
Comment on lines
+67
to
+69
| // Automatically reverts all deployment changes on failure. | ||
| // Default is true. | ||
| AutoRollback *bool `json:"autoRollback,omitempty" default:"true"` |
There was a problem hiding this comment.
[imo] How about adding the comment to explain this is only for the v1 for now? It's because we avoid using it on the current version.
There was a problem hiding this comment.
I think we can add a deprecated note to the Input.AutoRollback 👍
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
t-kikuc
approved these changes
Jul 18, 2024
This was referenced Jul 29, 2024
Merged
This was referenced Aug 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The auto rollback configuration is generic for all applications kinds, so it should be placed in
spec.Plannerinstead ofspec(Kind).InputWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: