Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EphemeralStorage in TaskDefinition [ECS] #5063

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jul 22, 2024

What this PR does / why we need it:

Enabled to configure ephemeralStorage in TaskDefinition.

Because it is not supported yet.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

How to use it

You can configure like this in your taskdef.yaml:
image

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc added the kind/enhancement New feature or request label Jul 22, 2024
@t-kikuc t-kikuc enabled auto-merge (squash) July 22, 2024 10:11
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.72%. Comparing base (586ae47) to head (38db67c).
Report is 179 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/piped/platformprovider/ecs/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5063   +/-   ##
=======================================
  Coverage   22.71%   22.72%           
=======================================
  Files         410      410           
  Lines       43513    43514    +1     
=======================================
+ Hits         9885     9889    +4     
+ Misses      32849    32847    -2     
+ Partials      779      778    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t-kikuc t-kikuc merged commit 60c4a53 into master Jul 23, 2024
17 of 18 checks passed
@t-kikuc t-kikuc deleted the ecs-fargate-ephemeral-storage branch July 23, 2024 00:05
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
This was referenced Jul 26, 2024
ffjlabo pushed a commit that referenced this pull request Jul 29, 2024
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
t-kikuc added a commit that referenced this pull request Jul 29, 2024
)

* fix: upgrade dotenv from 8.2.0 to 8.6.0 (#5037)

Snyk has created this PR to upgrade dotenv from 8.2.0 to 8.6.0.

See this package in yarn:
dotenv

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* fix: upgrade @types/yup from 0.29.11 to 0.29.14 (#5038)

Snyk has created this PR to upgrade @types/yup from 0.29.11 to 0.29.14.

See this package in yarn:
@types/yup

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* fix: upgrade react-draggable from 4.4.3 to 4.4.6 (#5039)

Snyk has created this PR to upgrade react-draggable from 4.4.3 to 4.4.6.

See this package in yarn:
react-draggable

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* fix: upgrade clsx from 1.1.1 to 1.2.1 (#5040)

Snyk has created this PR to upgrade clsx from 1.1.1 to 1.2.1.

See this package in yarn:
clsx

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* add EphemeralStorage to RegisterTaskDefinition() (#5063)

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Remove platform provider migration ops task (#5065)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Remove unused dependencies: @date-io/dayjs, @material-ui/pickers (#5070)

* yarn remove @date-io/dayjs

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* yarn remove @material-ui/pickers

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Fix type for grpcWeb.Error to grpcweb.RpcError (#5072)

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

* Release/init v0.48.3 (#5090)

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants