Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs and a description of supported SSO services #5075

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jul 26, 2024

What this PR does / why we need it:

Removed not-supported services from docs and a description on console like #5044.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.79%. Comparing base (5dc4ee3) to head (ce23409).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5075      +/-   ##
==========================================
- Coverage   22.80%   22.79%   -0.01%     
==========================================
  Files         410      410              
  Lines       43382    43382              
==========================================
- Hits         9895     9891       -4     
- Misses      32709    32712       +3     
- Partials      778      779       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc enabled auto-merge (squash) July 26, 2024 07:28
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t-kikuc t-kikuc merged commit 57e9cbf into master Jul 30, 2024
18 checks passed
@t-kikuc t-kikuc deleted the remove-google-sso-doc branch July 30, 2024 05:29
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants