Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lambda config docs #5087

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Fix Lambda config docs #5087

merged 11 commits into from
Jul 31, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jul 28, 2024

What this PR does / why we need it:

Fix Lambda config docs in the configuration-reference.
The main changes are:

  • Fix field names: UpperCamelCase -> lowerCamelCase
  • Fix field names:
    • ImageURI -> image
    • SecurityGroupIDs -> securityGroupIds
    • SubnetIDs -> subnetIds
    • SourceCode -> source [edited in 709ac39]
  • Fix Required values and add explanations

For Reviewers

See function.go.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.83%. Comparing base (46b475c) to head (d5a5217).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5087      +/-   ##
==========================================
- Coverage   22.84%   22.83%   -0.01%     
==========================================
  Files         409      409              
  Lines       43300    43300              
==========================================
- Hits         9891     9889       -2     
- Misses      32630    32633       +3     
+ Partials      779      778       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

khanhtc1202
khanhtc1202 previously approved these changes Jul 28, 2024
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

… function.go

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@t-kikuc t-kikuc merged commit edebc9f into master Jul 31, 2024
18 checks passed
@t-kikuc t-kikuc deleted the doc-lambda-config branch July 31, 2024 02:44
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants