-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the Grafana chart version #5103
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5103 +/- ##
==========================================
- Coverage 22.83% 22.80% -0.03%
==========================================
Files 409 409
Lines 43338 43338
==========================================
- Hits 9895 9885 -10
- Misses 32665 32674 +9
- Partials 778 779 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
What this PR does / why we need it:
Upgrade the Grafana sub-chart in the pipecd chart.
Which issue(s) this PR fixes:
Part of #4431
Does this PR introduce a user-facing change?: Yes
The control plane manager who uses the pipecd charts and specifies the non-default image registry for the Grafana sub-chart
Yes
Specify image registry not with
grafana.global.image.registry
but withgrafana.global.imageRegistry
.