Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for app-manifest-cache-count #5131

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Aug 13, 2024

What this PR does / why we need it:

as title

Which issue(s) this PR fixes:

Follow #5108

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.80%. Comparing base (378ab0f) to head (a58dd2c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5131      +/-   ##
==========================================
+ Coverage   22.79%   22.80%   +0.01%     
==========================================
  Files         412      412              
  Lines       43827    43827              
==========================================
+ Hits         9989     9996       +7     
+ Misses      33050    33044       -6     
+ Partials      788      787       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffjlabo ffjlabo merged commit c75fabe into master Aug 13, 2024
16 of 18 checks passed
@ffjlabo ffjlabo deleted the add-docs-for-cache-limit branch August 13, 2024 06:45
@github-actions github-actions bot mentioned this pull request Aug 15, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants