Discard the otel logs #5146
Merged
Discard the otel logs #5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5146 +/- ##
=======================================
Coverage 22.79% 22.79%
=======================================
Files 412 412
Lines 43827 43832 +5
=======================================
+ Hits 9989 9992 +3
- Misses 33050 33052 +2
Partials 788 788 ☔ View full report in Codecov by Sentry. |
ffjlabo
reviewed
Aug 26, 2024
Comment on lines
+245
to
+249
| // if control plane's flag monitoring.enabled is false, otel provider logs errors. | ||
| // it's no problem but we don't want to see it. | ||
| // so we discard the logger. | ||
| otel.SetLogger(logr.Discard()) | ||
|
|
There was a problem hiding this comment.
📝 It's ok for now. However, if users want to investigate the otel behavior, it might be necessary.
If so, it would be nice to add the flag on whether to show the log.
ffjlabo
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If the control plane disables the monitoring feature, piped's OTEL TracerProvider logs some errors because the otel collector does not exist.
It's not a problem, but we don't want to see error logs.
So we discard the otel logs.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: