-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note to RELEASE file #5149
Add note to RELEASE file #5149
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5149 +/- ##
=======================================
Coverage 22.79% 22.79%
=======================================
Files 412 412
Lines 43827 43827
=======================================
+ Hits 9989 9992 +3
+ Misses 33050 33047 -3
Partials 788 788 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good note👍
make release/init
worked well even after fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
* Add note to RELEASE file (#5149) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Fix the kubernetes manifest diff (#5154) * Add TestLoadAndDiff Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com> * Make testcase smaller Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com> * Separate test cases Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com> * Add test cases Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com> * FIx the k8s diff normalize both of old and new manifests Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com> * Rename the testcase Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com> --------- Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Release v0.48.7 (#5157) Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
What this PR does / why we need it:
Add note to aware release facilitator to use
make release
command instead of update this file manually 😅Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: