Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list deprecated api for testing #5200

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

TODO: Revert later

Which issue(s) this PR fixes:

Part of #5197

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) September 6, 2024 09:39
@khanhtc1202 khanhtc1202 merged commit 5b8b040 into master Sep 6, 2024
13 of 15 checks passed
@khanhtc1202 khanhtc1202 deleted the update-list-deprecated-api branch September 6, 2024 09:42
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.82%. Comparing base (78b7b3e) to head (5c833b2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/server/grpcapi/web_api.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5200   +/-   ##
=======================================
  Coverage   22.82%   22.82%           
=======================================
  Files         420      420           
  Lines       45302    45302           
=======================================
  Hits        10340    10340           
  Misses      34166    34166           
  Partials      796      796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

khanhtc1202 added a commit that referenced this pull request Sep 6, 2024
khanhtc1202 added a commit that referenced this pull request Sep 6, 2024
This reverts commit 5b8b040.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202 added a commit that referenced this pull request Sep 6, 2024
This reverts commit 5b8b040.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants