Sort subnet in live manifest of ECS Drift Detection #5254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoangNguyen689
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo,
t-kikuc and
Warashi
as code owners
HoangNguyen689
force-pushed
the
remove-order-subnet-in-head-manifest
branch
from
0924de6
to
53664af
Compare
|
@HoangNguyen689 the solution might be one of: |
|
@t-kikuc |
Signed-off-by: HoangNguyen689 <ndhoang.bk.hedspi@gmail.com>
HoangNguyen689
force-pushed
the
remove-order-subnet-in-head-manifest
branch
from
ff48a12
to
543beaf
Compare
HoangNguyen689
changed the title
|
@t-kikuc |
|
@HoangNguyen689 |
|
@HoangNguyen689 That's why, sorting both live and head manifests is the best. |
t-kikuc
approved these changes
Oct 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
Signed-off-by: HoangNguyen689 <ndhoang.bk.hedspi@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
t-kikuc
added a commit
that referenced
this pull request
Oct 8, 2024
#5263 (#5265) * Fix panic in ECS driftdetection when a taskdef in livestates does not exist (#5240) * Generate v0.49.x docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix: avoid panic when live taskdef does not exist Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Upgrade aws-sdk-go-v2 (#5241) * Generate v0.49.x docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * upgrade aws-sdk-go-v2 Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * upgrade aws-sdk-go-v2/**/* Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix compile errors caused by the breaking change Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix a test due to added RestartPolicy Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix: avoid panic when live taskdef does not exist Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix go.sum by `make update/go-deps` Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Remove an unused field 'configFilePathInGitRepo' (#5248) * Generate v0.49.x docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * remove unused field 'configFilePathInGitRepo' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Support fetching a piped config from AWS SSM Parameter Store (#5249) * Generate v0.49.x docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add --aws-ssm-parameter Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add config-aws-ssm-parameter to piped Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * update docs of runtime options Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Remove subnet ordering in head manifest (#5254) Signed-off-by: HoangNguyen689 <ndhoang.bk.hedspi@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update quickstart header note (#5255) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update feature status (#5256) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Support directly designating a gitSSHKey instead of File for launcher (#5258) * Generate v0.49.x docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add --git-ssh-key-env Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * update docs: add '--git-ssh-key-env' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add '\n' at the end of ssh key Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Directly use data instead of env Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Clarify the flag description Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix error message: 'and' -> 'or' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Add workflow steps to build and publish quickstart manifests (#5260) Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update workflow not to run by matrix (#5262) Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update RELEASE to v0.49.1 and update v0.49.x docs (#5263) * update RELEASE to v0.49.1 Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * update docs of v0.49.x by `make release version=v0.49.1` Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: HoangNguyen689 <ndhoang.bk.hedspi@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com> Co-authored-by: HoangNguyen689 <ndhoang.bk.hedspi@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Issue: When viewing the details of the drift-detector on the PipeCD console, the order of subnets in the live state (red) matches the defined resource (servicedef.yaml), but the Git state (green) shows subnets in reverse order.
Investigation: After reviewing the AWS DescribeServices documentation, I found no evidence that AWS guarantees any sorting of subnets in the returned live state. It appears that PipeCD fetches the live state using DescribeServices.
Proposed Solution: I suggest adding explicit sorting of subnets in PipeCD before performing comparisons in the drift detector to avoid confusion.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: No