fix(controller): handle nil processedTmpl in DAGs (argoproj#13548)

Signed-off-by: joey <zchengjoey@gmail.com>
pipekit · Sep 19, 2024 · d1f569b · d1f569b
1 parent b3ec695
commit d1f569b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/workflow/controller/dag.go b/workflow/controller/dag.go
@@ -431,7 +431,11 @@ func (woc *wfOperationCtx) executeDAGTask(ctx context.Context, dagCtx *dagContex
 
 	if node != nil && node.Fulfilled() {
 		// Collect the completed task metrics
-		_, tmpl, _, _ := dagCtx.tmplCtx.ResolveTemplate(task)
+		_, tmpl, _, tmplErr := dagCtx.tmplCtx.ResolveTemplate(task)
+		if tmplErr != nil {
+			woc.markNodeError(node.Name, tmplErr)
+			return
+		}
 		if err := woc.mergedTemplateDefaultsInto(tmpl); err != nil {
 			woc.markNodeError(node.Name, err)
 			return
@@ -449,7 +453,7 @@ func (woc *wfOperationCtx) executeDAGTask(ctx context.Context, dagCtx *dagContex
 		}
 
 		// Release acquired lock completed task.
-		if tmpl != nil {
+		if processedTmpl != nil {
 			woc.controller.syncManager.Release(woc.wf, node.ID, processedTmpl.Synchronization)
 		}