feat(evmstaking): replace staking keeper endblocker #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xHansLee
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal and
leeren
as code owners
0xHansLee
force-pushed
the
feat/replace-staking-endblocker
branch
from
38493f3
to
9ed02e5
Compare
0xHansLee
changed the title
jdubpark
approved these changes
Oct 16, 2024
jdubpark
reviewed
Oct 16, 2024
Comment on lines
-92
to
-113
| spendableAmount := k.bankKeeper.SpendableCoin(ctx, delegatorAddr, sdk.DefaultBondDenom).Amount | ||
| if spendableAmount.IsZero() { | ||
| log.Warn(ctx, "No spendable coins for undelegation", | ||
| errors.New("no spendable coins for undelegation"), | ||
| "delegator", entry.delegatorAddress, | ||
| "validator", entry.validatorAddress, | ||
| "original_amount", entry.amount.String()) | ||
|
|
||
| continue | ||
| } | ||
|
|
||
| // If the requested undelegation amount is greater than the spendable amount, set the real undelegation amount to | ||
| // the total spendable amount. | ||
| if entry.amount.GT(spendableAmount) { | ||
| entry.amount = spendableAmount | ||
| log.Warn(ctx, "Spendable amount is less than the requested undelegation amount", | ||
| errors.New("spendable amount is less than the requested undelegation amount"), | ||
| "delegator", entry.delegatorAddress, | ||
| "validator", entry.validatorAddress, | ||
| "requested_amount", entry.amount.String(), | ||
| "spendable_amount", spendableAmount.String()) | ||
| } |
There was a problem hiding this comment.
Should we add tests to ensure this invariance is not broken? cc @limengformal
We should also add the crisis module for invariance checks, cc @edisonz0718.
There was a problem hiding this comment.
Will add a test to cover that this invariance is not broken in the following PR.
0xHansLee
force-pushed
the
feat/replace-staking-endblocker
branch
from
9ed02e5
to
bd0d8fc
Compare
0xHansLee
force-pushed
the
feat/replace-staking-endblocker
branch
from
bd0d8fc
to
9befa97
Compare
Binary uploaded successfully 🎉📦 Version Name: 0.12.0-d2e195c |
leeren
pushed a commit
that referenced
this pull request
Oct 16, 2024
leeren
pushed a commit
that referenced
this pull request
Oct 16, 2024
leeren
added a commit
that referenced
this pull request
Oct 16, 2024
* chore(release): release version 0.12.1 unstable * feat(epochs): revert epoch module (#198) * feat(api): revert add epochs api * feat(epochs): revert porting epochs module * feat(evmstaking): use deterministic cosmos sdk (#211) * feat(evmstaking): replace staking keeper endblocker (#209) --------- Co-authored-by: Hans Lee <38912532+0xHansLee@users.noreply.github.com> Co-authored-by: Zerui Ge <gezerui1997@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this implementation, I replaced the EndBlocker of staking keeper.
It now returns the array of completed unbonding, so we can use them for processing withdrawal.
issue: #197