Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wip): restrict name and symbol to pure #292

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

sebsadface
Copy link
Member

@sebsadface sebsadface commented Oct 23, 2024

restrict function mutability of symbol and name to pure

issue: none

@sebsadface sebsadface changed the title fix(wip): restrict state mutability of name() and symbol() to pure fix(wip): restrict name() and symbol() to pure Oct 23, 2024
@sebsadface sebsadface changed the title fix(wip): restrict name() and symbol() to pure fix(wip): restrict name() and symbol() to pure Oct 23, 2024
@sebsadface sebsadface changed the title fix(wip): restrict name() and symbol() to pure fix(wip): restrict name and symbol to pure Oct 23, 2024
Copy link
Contributor

@ezreal1997 ezreal1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeoHChen LeoHChen merged commit c7573a2 into piplabs:main Oct 23, 2024
8 of 20 checks passed
@sebsadface sebsadface deleted the fix-wip branch October 23, 2024 21:25
Copy link

Binary uploaded successfully 🎉

📦 Version Name: 0.12.1-c7573a2
📦 Download Source: AWS S3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants