fix(evmstaking): roll back tokens to be burnt when msg failed #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xHansLee
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal and
leeren
as code owners
limengformal
approved these changes
Oct 30, 2024
0xHansLee
force-pushed
the
hans/handle-failed-create-val-msg
branch
from
b53a12e to
025a00a
Compare
ezreal1997
force-pushed
the
rayden/fix-address
branch
from
a37f7f0 to
f2c0770
Compare
0xHansLee
force-pushed
the
hans/handle-failed-create-val-msg
branch
from
025a00a to
f970930
Compare
Binary uploaded successfully 🎉📦 Version Name: 0.12.1-unstable-c4c0d99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was due to that our evmstaking module don't handle errors while processing evm events.
When errors occur while processing
CreateValidatororStakeevm events, the minted tokens should be sent back to module and burnt.issue: #262