Hide tab preview panel when the sidebar is closed

piroor · Nov 28, 2024 · c6c64e0 · c6c64e0
1 parent c826d85
commit c6c64e0
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 1 deletion.
diff --git a/webextensions/common/constants.js b/webextensions/common/constants.js
@@ -34,6 +34,7 @@ export const kCOMMAND_CONFIRM_TO_CLOSE_TABS          = 'treestyletab:confirm-to-
 export const kCOMMAND_SHOW_DIALOG                    = 'treestyletab:show-dialog';
 export const kCOMMAND_NOTIFY_BACKGROUND_READY        = 'treestyletab:notify-background-ready';
 export const kCOMMAND_NOTIFY_CONNECTION_READY        = 'treestyletab:notify-connection-ready';
+export const kCOMMAND_NOTIFY_SIDEBAR_CLOSED          = 'treestyletab:notify-sidebar-closed';
 export const kCOMMAND_NOTIFY_TAB_CREATING            = 'treestyletab:notify-tab-creating';
 export const kCOMMAND_NOTIFY_TAB_CREATED             = 'treestyletab:notify-tab-created';
 export const kCOMMAND_NOTIFY_TAB_UPDATED             = 'treestyletab:notify-tab-updated';

diff --git a/webextensions/common/sidebar-connection.js b/webextensions/common/sidebar-connection.js
@@ -10,7 +10,8 @@ import EventListenerManager from '/extlib/EventListenerManager.js';
 import {
   log as internalLogger,
   mapAndFilterUniq,
-  configs
+  configs,
+  wait,
 } from './common.js';
 import * as Constants from './constants.js';
 import * as TabsStore from './tabs-store.js';
@@ -223,6 +224,32 @@ if (Constants.IS_BACKGROUND) {
       mReceivers.delete(windowId);
       mFocusState.delete(windowId);
       onDisconnected.dispatch(windowId, connections.size);
+
+      // We need to notify this to some conetnt scripts, to destroy themselves.
+      /*
+      browser.runtime.sendMessage({
+        type: Constants.kCOMMAND_NOTIFY_SIDEBAR_CLOSED,
+        windowId,
+      });
+      */
+      browser.windows.get(windowId, { populate: true }).then(async win => {
+        let count = 0;
+        for (const tab of win.tabs) {
+          count++;
+          if (count >= 20) {
+            // We should not block too long seconds on too much tabs case.
+            await wait(10);
+            count = 0;
+          }
+          try {
+            browser.tabs.sendMessage(tab.id, {
+              type: Constants.kCOMMAND_NOTIFY_SIDEBAR_CLOSED,
+            });
+          }
+          catch (_error) {
+          }
+        }
+      });
     };
     const receiver = message => {
       if (Array.isArray(message))

diff --git a/webextensions/resources/tab-preview-frame.js b/webextensions/resources/tab-preview-frame.js
@@ -166,6 +166,12 @@ try{
           panel.classList.add('hidden');
         }
         break;
+
+      case 'treestyletab:notify-sidebar-closed':
+        if (panel) {
+          panel.classList.add('hidden');
+        }
+        break;
     }
   });