You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is an inconsistency between show_topic-topn and show_topics-num_words in LdaModel which is replicated along other topic models in order to standardise the api.
show_topics and print_topics were standardised among topic models in #755 to match LdaModel to use num_words as the argument names were confusing.
Later #771 changed show_topic and print_topic to use num_words just in ldamallet. That was a way to standardise it with show_topics, but in retrospect it was not the best move.
Then print_topic was changed back to use topn like all the other models do when ldamallet inherited from BaseTopicModel. Though show_topic has remained - that is the inconsistency that should be resolved here.
The text was updated successfully, but these errors were encountered:
There is an inconsistency between
show_topic
-topn
andshow_topics
-num_words
inLdaModel
which is replicated along other topic models in order to standardise the api.show_topics
andprint_topics
were standardised among topic models in #755 to matchLdaModel
to usenum_words
as the argument names were confusing.Later #771 changed
show_topic
andprint_topic
to usenum_words
just inldamallet
. That was a way to standardise it withshow_topics
, but in retrospect it was not the best move.Then
print_topic
was changed back to usetopn
like all the other models do when ldamallet inherited fromBaseTopicModel
. Thoughshow_topic
has remained - that is the inconsistency that should be resolved here.The text was updated successfully, but these errors were encountered: