Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate annoy tutorials - annoytutorial.ipynb & annoytutorial-text8.ipynb ? #1415

Closed
gojomo opened this issue Jun 14, 2017 · 4 comments
Closed
Labels
bug Issue described a bug difficulty easy Easy issue: required small fix good first issue Issue for new contributors (not required gensim understanding + very simple)

Comments

@gojomo
Copy link
Collaborator

gojomo commented Jun 14, 2017

There seem to be two (nearly?) identical ANNOY tutorial notebooks:

https://github.com/RaRe-Technologies/gensim/blob/develop/docs/notebooks/annoytutorial-text8.ipynb

https://github.com/RaRe-Technologies/gensim/blob/develop/docs/notebooks/annoytutorial.ipynb

Maybe a merge error retained the file under an older name? Seems there should be only one, probably the one with the longer more-detailed name.

@Quole @vochicong @pmbaumgartner

@pmbaumgartner
Copy link
Contributor

I think this is a merge error. I built the new tutorial under annoytutorial-text8.ipynb, then renamed the file to annoytutorial.ipynb to replace the original, as requested.

@menshikh-iv menshikh-iv added bug Issue described a bug difficulty easy Easy issue: required small fix test before incubator labels Oct 2, 2017
@souravsingh
Copy link
Contributor

@menshikh-iv I believe the issue can be closed.

@menshikh-iv
Copy link
Contributor

@souravsingh Not now, because I'll remove all duplicates in new PR (duplicates existing now here)

@menshikh-iv menshikh-iv added good first issue Issue for new contributors (not required gensim understanding + very simple) and removed test before incubator labels Oct 16, 2017
@Karamax
Copy link
Contributor

Karamax commented Oct 21, 2017

Solved 1640.

horpto pushed a commit to horpto/gensim that referenced this issue Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue described a bug difficulty easy Easy issue: required small fix good first issue Issue for new contributors (not required gensim understanding + very simple)
Projects
None yet
Development

No branches or pull requests

5 participants