Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python warnings (occur during testing) #1519

Closed
menshikh-iv opened this issue Aug 4, 2017 · 9 comments
Closed

Fix python warnings (occur during testing) #1519

menshikh-iv opened this issue Aug 4, 2017 · 9 comments
Labels
difficulty medium Medium issue: required good gensim understanding & python skills good first issue Issue for new contributors (not required gensim understanding + very simple) testing Issue related with testing (code, documentation, etc)

Comments

@menshikh-iv
Copy link
Contributor

Need to fix warnings from interpreter (during test run).
It's easy to see all:
python -Wd -t -3 for python2
python -Wd -b for python3

@menshikh-iv menshikh-iv added the testing Issue related with testing (code, documentation, etc) label Aug 4, 2017
@menshikh-iv
Copy link
Contributor Author

I looked at it and realized that it makes no sense to do it separately. This can be done in the process of refactoring tests (in the future).

@menshikh-iv menshikh-iv added difficulty medium Medium issue: required good gensim understanding & python skills test before incubator labels Oct 2, 2017
@menshikh-iv menshikh-iv added good first issue Issue for new contributors (not required gensim understanding + very simple) needs domain knowledge and removed test before incubator labels Oct 16, 2017
@poornagurram
Copy link
Contributor

poornagurram commented Oct 25, 2017

@menshikh-iv I would like to submit a PR for this. I am a beginner contributor. can you elaborate more on this?

@menshikh-iv
Copy link
Contributor Author

menshikh-iv commented Oct 26, 2017

@poornagurram of course, submit your PR.

@poornagurram
Copy link
Contributor

@menshikh-iv I didn't get a clear idea about this issue can you elaborate more on this.

@menshikh-iv
Copy link
Contributor Author

menshikh-iv commented Oct 26, 2017

@poornagurram of course,

Firstly (for simple investigation) you need to run tests with python3 and enabled warnings, howto:

  • Clone gensim repo
  • Create clean venv
  • pip install -e .[test] in gensim folder
  • python -Wd -b setup.py tests

you'll see many different warnings (about unclosed files, division, etc), you need to go to concrete tests that generate this warning, fix warnings and submit PR.

@menshikh-iv
Copy link
Contributor Author

Many ResourseWarning from smart_open, this part fixed in smart_open/140, another yet part fixed in #1660

@orsonadams
Copy link

Is this still a good beginner contrib issue? Would like to have a look. @menshikh-iv

@menshikh-iv
Copy link
Contributor Author

@ParseThis this is a good issue for start, but need to make many small changes (if you have enough time - you are welcome)

@menshikh-iv
Copy link
Contributor Author

I fixed almost all of it in #2191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty medium Medium issue: required good gensim understanding & python skills good first issue Issue for new contributors (not required gensim understanding + very simple) testing Issue related with testing (code, documentation, etc)
Projects
None yet
Development

No branches or pull requests

3 participants