-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python warnings (occur during testing) #1519
Comments
I looked at it and realized that it makes no sense to do it separately. This can be done in the process of refactoring tests (in the future). |
@menshikh-iv I would like to submit a PR for this. I am a beginner contributor. can you elaborate more on this? |
@poornagurram of course, submit your PR. |
@menshikh-iv I didn't get a clear idea about this issue can you elaborate more on this. |
@poornagurram of course, Firstly (for simple investigation) you need to run tests with python3 and enabled warnings, howto:
you'll see many different warnings (about unclosed files, division, etc), you need to go to concrete tests that generate this warning, fix warnings and submit PR. |
Many |
Is this still a good beginner contrib issue? Would like to have a look. @menshikh-iv |
@ParseThis this is a good issue for start, but need to make many small changes (if you have enough time - you are welcome) |
I fixed almost all of it in #2191 |
Need to fix warnings from interpreter (during test run).
It's easy to see all:
python -Wd -t -3
for python2python -Wd -b
for python3The text was updated successfully, but these errors were encountered: