Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR related to issue #1269 #1655

Closed
wants to merge 3 commits into from
Closed

PR related to issue #1269 #1655

wants to merge 3 commits into from

Conversation

poornagurram
Copy link
Contributor

Added function to give preproduction ready dictionary of most similar words and ability to pass custom most similar words dict

Added function to give preproduction ready dictionary of most similar words and ability to pass custom most similar words dict
@menshikh-iv
Copy link
Contributor

menshikh-iv commented Oct 26, 2017

@poornagurram please don't edit notebooks manually (you break current notebook, it does not display correctly).
Run ipython notebook, open in the browser, make all needed changes, re-run notebook (to make sure that everything works) and after - commit/push.

Also, please add an example of usage for this function (because now this doesn't use anywhere) and a short description, why this functionality can be useful.

@poornagurram poornagurram changed the title Fix #1269 PR related to issue #1269 Oct 26, 2017
@poornagurram
Copy link
Contributor Author

poornagurram commented Oct 26, 2017

@menshikh-iv this PR is a reference to the issue #1269.

@menshikh-iv
Copy link
Contributor

Yes, my mistake, thanks @poornagurram

Changes the assertEquals to assertEqual to prevent from deprecation
@menshikh-iv
Copy link
Contributor

@poornagurram please firx ipython notebook here and move commits for #1519 to distinct PR (please don't mix up different fixes for unrelated issues)

@menshikh-iv
Copy link
Contributor

I close this PR, because it's easier to make new with needed commits for #1269 instead reverting & fixing here.

Please make new PR with example in notebook (don't forget about the comments above)

@poornagurram
Copy link
Contributor Author

Yeah sure thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants