Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for scikit-learn installation #1350

Merged
merged 1 commit into from
May 22, 2017
Merged

Add test for scikit-learn installation #1350

merged 1 commit into from
May 22, 2017

Conversation

souravsingh
Copy link
Contributor

Fixes part of #1324

@tmylk tmylk merged commit 80cc564 into piskvorky:develop May 22, 2017
@tmylk
Copy link
Contributor

tmylk commented May 22, 2017

Thanks for the PR

@souravsingh souravsingh deleted the fix-sklearn branch May 23, 2017 02:27
from sklearn.feature_extraction.text import CountVectorizer
from sklearn.datasets import load_files
from sklearn import linear_model
except:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naked except: bad practice. Use except ImportError, or at least except Exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants