-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subpackage refactor. Fix 1584 #1618
Conversation
What's done:
I re-create PR according to discussion from #1607 and #1584, please review again @piskvorky @macks22 |
Regarding the various Removing them will break some functionality, because the These parameters are probably better served as proper CLI options, rather than encoded in the filename. Just saying that simply removing the "duplicates" will prevent users from accessing existing functionality. |
@piskvorky |
Close (because conflict is really big), I'll re-create it with additions when we plan to create major release |
Fix for #1584.