Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Updates to poincare notebooks #1774

Merged
merged 5 commits into from
Dec 12, 2017
Merged

Conversation

jayantj
Copy link
Contributor

@jayantj jayantj commented Dec 10, 2017

Makes the following updates to the tutorial notebook -

  1. Removes minute technical details and evaluation results
  2. Adds links to detailed blog post and other useful links

Evaluation notebook -

  1. Adds results for regularized models
  2. HTML tables instead of ascii-tables to easily publish in blogs.

@janpom
Copy link
Contributor

janpom commented Dec 11, 2017

This looks good. One minor thing: The "Dimensions" label is off in the results table. It should span all the dimension columns and shouldn't span the "Metric" column.

@menshikh-iv
Copy link
Contributor

@jayantj

  • "Note that not all the above libraries are part of the gensim dependencies, so they might need to be installed separately. These requirements are listed in the poincare requirements.txt" - please add cell with pip install ... line instead (this file already does not exist)
  • This is the second rename evaluation -> tutorial -> evaluation, please explain what is happening

@jayantj
Copy link
Contributor Author

jayantj commented Dec 11, 2017

@menshikh-iv do you mean I should hardcode the pip installs in the notebook itself?
Regarding rename: this PR doesn't actually rename anything, it looks like it has been removed because it removes a lot of the plotly graphs from tutorial. The tutorial notebook and evaluation notebook both still exist.

@menshikh-iv
Copy link
Contributor

@jayantj yes, this is simpler and easy-to-edit if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants