Fixed Typo and increased performance in analyze_sentence #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JonathanHourany . Looking at the code, that whole "trick" is questionable though -- adding two lists together will create a new list, which is a very costly operation in such a tight spot. So I don't think that's a good idea in the first place, but we wanted to replace that code by an optimized Cython loop anyway… |
|
I agree, seems it'd be better to append |
|
Yes please! |
As @piskvorky pointed out, using `s + [None]`on line 149 creates a new list, an expensive operation considering the goal is just to append `None` to an already existing list. Using `append` increases performance by 5 micro seconds per function call on my system
JonathanHourany
changed the title
|
Thanks @JonathanHourany ! Congrats on your first Gensim contribution 🏅 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type on line 147. Sentence is "...happy ending has it won't..." where "has" should be "as"