Fix citation of Mikolov paper #2098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contribution @davidchall, this will be fixed as part of #2096. |
menshikh-iv
added a commit
that referenced
this pull request
Jun 21, 2018
menshikh-iv
pushed a commit
that referenced
this pull request
Jun 22, 2018
* doc fixes * doc fixes to matutils * docsim doc fixes * doc fixes to interfaces module * doc fixes to Dictionary * doc fixes to MatrixMarket classes * doc fixes to WikiCorpus * minor code style changes in HashDictionary * fixing TfidfModel bugs + docs * fixes to phrases docs * fix PEP8 * fix documentation building * cleanup mmcorpus-related * cleanup dictionary * cleanup hashdictionary * cleanup wikicorpus * cleanup interfaces * cleanup matutils * rename smartirs signature * minor docs style fixes * regenerate *.c for mmreader (after last Radim fix) * fix bool parameters * regenerate _mmreader.c again * cleanup phrases * cleanup utils * Fix paper for phrases according to #2098, catch by @davidchall * cleanup docsim * - cleanup tfidfmodel - fix bug in smartirs_normalize (old version correct!) - remove persistence test & remove old models from repo (by rename reason) * typo fix * add back smartirs tests * retrying saved test files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default scorer used by the phraser is Equation 6 from https://arxiv.org/pdf/1310.4546.pdf
I've updated citations in the gensim documentation to reflect this. I also fixed a typo in the docstring, which led to an incorrect formula.