-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temporarily disable failing unit test #2866
Conversation
In this case, "everything" really means "everything, except for stuff that we know is broken". Remember, at any one time gensim literally has dozens of bugs. Can you imagine what life for the maintainer would be like if each of those bugs caused a test to fail on each build?
No, that's a false analogy. Let me adjust it so it reflects reality a little better. We're sitting in a room working on an important time-sensitive project. Time is short, because everybody has a life outside of gensim. Suddenly, one of the many smoke detectors in the room starts beeping (remember, we have multiple tests that cover that functionality, and only one of them fails: Py3.8 under Travis). Our options:
(1) is a PITA. (2) violates our priorities. (3) is this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK but can you remind me – why are we using Travis? I thought we switched the CI to Azure?
Travis does our Linux builds. Azure is Windows. |
Closing in favor of #2868 |
The test was passing 10 days ago, but now it fails. The failure affects #2864, #2867 and possibly other in-flight PRs.
My plan is: