Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Refactor phrases #2976

Merged
merged 5 commits into from
Oct 10, 2020
Merged

[MRG] Refactor phrases #2976

merged 5 commits into from
Oct 10, 2020

Commits on Oct 8, 2020

  1. refactor phrases

    @piskvorky
    piskvorky committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    b40c601 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. fix phrases tests

    @piskvorky
    piskvorky committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    6f4053b View commit details
    Browse the repository at this point in the history

  2. clean up rendered docs for phrases

    @piskvorky
    piskvorky committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    092b512 View commit details
    Browse the repository at this point in the history

  3. fix sklearn_api.phrases tests + docs 

    - removed testing of loading of old models for backward compatibility, because the wrappers use plain pickle and so don't support SaveLoad overrides
    @piskvorky
    piskvorky committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    1acb47c View commit details
    Browse the repository at this point in the history

  4. fix flake8 warnings in docstrings

    @piskvorky
    piskvorky committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    aaa79dd View commit details
    Browse the repository at this point in the history