Allow overriding the Cython version requirement #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @pabs3 , what are you working on, what's the motivation here? The PR looks simple enough but could use some context. |
|
I have packaged gensim for Debian and the version of Cython available
in Debian unstable is often not the same version as the one in the
gensim setup.py. I patched out the version pinning in the Debian
package but I think it would be better to have an official override
mechanism so that updating the patch is no longer needed.
…--
bye,
pabs
https://bonedaddy.net/pabs3/
|
piskvorky
approved these changes
Apr 13, 2022
Use an environment variable for this since it is often easier to set in a build wrapper rather than trying to override command-line options in the right layer of a multi-layer build wrapper and it also requires a lot less code to do the override. This will be useful for using alpha versions of Cython or old versions of Cython provided by the distros or specific versions that fix certain bugs.
pabs3
force-pushed
the
override-cython-requires
branch
from
d24c5ea
to
629c929
Compare
mpenkov
approved these changes
May 5, 2022
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an environment variable for this since it is often easier to set in a
build wrapper rather than trying to override command-line options in the
right layer of a multi-layer build wrapper and it also requires a lot less
code to do the override.
This will be useful for using alpha versions of Cython or old versions of
Cython provided by the distros or specific versions that fix certain bugs.