Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up references to Morfessor, tox and gensim.models.wrappers #3345

Merged
merged 3 commits into from
May 5, 2022

Conversation

pabs3
Copy link
Contributor

@pabs3 pabs3 commented May 5, 2022

They were dropped in 2021 and 2022.

Closes: #3342
Fixes: commit acce8a2
Fixes: commit 3ce81a4
Fixes: commit a21d9cc

pabs3 added 3 commits May 5, 2022 15:00
It was dropped from usage in 2022.

Fixes: commit acce8a2
Usage of tox was dropped in 2022.

Where necessary, replace tox commands with the current equivalent.

Fixes: commit 3ce81a4
They were all removed in 2021.

TestDtmModel escaped being noticed via test failures because all the tests
it runs are skipped without the DTM_PATH environment variable being set.

Fixes: commit a21d9cc
@mpenkov
Copy link
Collaborator

mpenkov commented May 5, 2022

Looks good! Thank you for the cleanup @pabs3

@mpenkov mpenkov merged commit eeb7e86 into piskvorky:develop May 5, 2022
@pabs3 pabs3 deleted the cleanup-removed-things branch May 5, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup of vestigial Morfessor, Varembed, gensim.models.wrapper(s) references?
2 participants